Mirror/SponsorBlock
1
0
Fork 0
mirror of https://github.com/ajayyy/SponsorBlock.git synced 2025-12-11 14:07:13 +03:00
Code Issues Packages Projects Releases Wiki Activity

Always use parentheses in unclear nesting

Browse Source
This commit is contained in:
mschae23
2025-09-23 20:38:54 +02:00
parent 2a2d9de817
commit 8d0d71b0f3
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/components/options/AdvancedSkipOptionsComponent.tsx
View File

@@ -86,7 +86,7 @@ function configToText(config: AdvancedSkipRule[]): string {
}
result += "if ";
result += predicateToText(rule.predicate, PredicateOperator.Or);
result += predicateToText(rule.predicate, null);
switch (rule.skipOption) {
case CategorySkipOption.Disabled:
@@ -111,15 +111,18 @@ function configToText(config: AdvancedSkipRule[]): string {
return result.trim();
}
function predicateToText(predicate: AdvancedSkipPredicate, highestPrecedence: PredicateOperator): string {
function predicateToText(predicate: AdvancedSkipPredicate, outerPrecedence: PredicateOperator | null): string {
if (predicate.kind === "check") {
return `${predicate.attribute} ${predicate.operator} ${JSON.stringify(predicate.value)}`;
} else {
let text: string;
if (predicate.operator === PredicateOperator.And) {
return `${predicateToText(predicate.left, PredicateOperator.And)} and ${predicateToText(predicate.right, PredicateOperator.And)}`;
text = `${predicateToText(predicate.left, PredicateOperator.And)} and ${predicateToText(predicate.right, PredicateOperator.And)}`;
} else { // Or
const text = `${predicateToText(predicate.left, PredicateOperator.Or)} or ${predicateToText(predicate.right, PredicateOperator.Or)}`;
return highestPrecedence == PredicateOperator.And ? `(${text})` : text;
text = `${predicateToText(predicate.left, PredicateOperator.Or)} or ${predicateToText(predicate.right, PredicateOperator.Or)}`;
}
return outerPrecedence !== null && outerPrecedence !== predicate.operator ? `(${text})` : text;
}
}