From 8d0d71b0f3ea158387aefca03bc74f075b4acbed Mon Sep 17 00:00:00 2001
From: mschae23 <46165762+mschae23@users.noreply.github.com>
Date: Tue, 23 Sep 2025 20:38:54 +0200
Subject: [PATCH] Always use parentheses in unclear nesting

---
 .../options/AdvancedSkipOptionsComponent.tsx        | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/src/components/options/AdvancedSkipOptionsComponent.tsx b/src/components/options/AdvancedSkipOptionsComponent.tsx
index 89b382a7..20a7ed47 100644
--- a/src/components/options/AdvancedSkipOptionsComponent.tsx
+++ b/src/components/options/AdvancedSkipOptionsComponent.tsx
@@ -86,7 +86,7 @@ function configToText(config: AdvancedSkipRule[]): string {
         }
 
         result += "if ";
-        result += predicateToText(rule.predicate, PredicateOperator.Or);
+        result += predicateToText(rule.predicate, null);
 
         switch (rule.skipOption) {
             case CategorySkipOption.Disabled:
@@ -111,15 +111,18 @@ function configToText(config: AdvancedSkipRule[]): string {
     return result.trim();
 }
 
-function predicateToText(predicate: AdvancedSkipPredicate, highestPrecedence: PredicateOperator): string {
+function predicateToText(predicate: AdvancedSkipPredicate, outerPrecedence: PredicateOperator | null): string {
     if (predicate.kind === "check") {
         return `${predicate.attribute} ${predicate.operator} ${JSON.stringify(predicate.value)}`;
     } else {
+        let text: string;
+
         if (predicate.operator === PredicateOperator.And) {
-            return `${predicateToText(predicate.left, PredicateOperator.And)} and ${predicateToText(predicate.right, PredicateOperator.And)}`;
+            text = `${predicateToText(predicate.left, PredicateOperator.And)} and ${predicateToText(predicate.right, PredicateOperator.And)}`;
         } else { // Or
-            const text = `${predicateToText(predicate.left, PredicateOperator.Or)} or ${predicateToText(predicate.right, PredicateOperator.Or)}`;
-            return highestPrecedence == PredicateOperator.And ? `(${text})` : text;
+            text = `${predicateToText(predicate.left, PredicateOperator.Or)} or ${predicateToText(predicate.right, PredicateOperator.Or)}`;
         }
+
+        return outerPrecedence !== null && outerPrecedence !== predicate.operator ? `(${text})` : text;
     }
 }