Merge pull request #572 from SashaXser/master

Promise.resolve and Using "forEach" instead of "map"

src/routes/getBranding.ts

@@ -131,18 +131,18 @@ export async function getVideoBrandingByHash(videoHashPrefix: VideoIDHash, servi
             };
         };
 
-        (await branding.titles).map((title) => {
+        (await branding.titles).forEach((title) => {
             title.title = title.title.replace("<", "‹");
 
             initResult(title);
             dbResult[title.videoID].titles.push(title);
         });
-        (await branding.thumbnails).map((thumbnail) => {
+        (await branding.thumbnails).forEach((thumbnail) => {
             initResult(thumbnail);
             dbResult[thumbnail.videoID].thumbnails.push(thumbnail);
         });
 
-        (await branding.segments).map((segment) => {
+        (await branding.segments).forEach((segment) => {
             initResult(segment);
             dbResult[segment.videoID].segments.push(segment);
         });
@@ -317,4 +317,4 @@ export async function getBrandingByHashEndpoint(req: Request, res: Response) {
         Logger.error(e as string);
         return res.status(500).send([]);
     }
-}
+}

src/utils/createMemoryCache.ts

@@ -23,9 +23,7 @@ export function createMemoryCache(memoryFn: (...args: any[]) => void, cacheTimeM
                 }
             }
             // create new promise
-            const promise = new Promise((resolve) => {
-                resolve(memoryFn(...args));
-            });
+            const promise = Promise.resolve(memoryFn(...args));
             // store promise reference until fulfilled
             promiseMemory.set(cacheKey, promise);
             return promise.then(result => {

src/utils/redis.ts

@@ -30,17 +30,17 @@ interface RedisSB {
 }
 
 let exportClient: RedisSB = {
-    get: () => new Promise((resolve) => resolve(null)),
-    getCompressed: () => new Promise((resolve) => resolve(null)),
-    set: () => new Promise((resolve) => resolve(null)),
-    setCompressed: () => new Promise((resolve) => resolve(null)),
-    setEx: () => new Promise((resolve) => resolve(null)),
-    setExCompressed: () => new Promise((resolve) => resolve(null)),
-    del: () => new Promise((resolve) => resolve(null)),
-    increment: () => new Promise((resolve) => resolve(null)),
-    sendCommand: () => new Promise((resolve) => resolve(null)),
-    quit: () => new Promise((resolve) => resolve(null)),
-    ttl: () => new Promise((resolve) => resolve(null)),
+    get: () => Promise.resolve(null),
+    getCompressed: () => Promise.resolve(null),
+    set: () => Promise.resolve(null),
+    setCompressed: () => Promise.resolve(null),
+    setEx: () => Promise.resolve(null),
+    setExCompressed: () => Promise.resolve(null),
+    del: () => Promise.resolve(null),
+    increment: () => Promise.resolve(null),
+    sendCommand: () => Promise.resolve(null),
+    quit: () => Promise.resolve(null),
+    ttl: () => Promise.resolve(null),
 };
 
 let lastClientFail = 0;