Merge pull request #450 from maximmax42/patch-1

Missing localized messages
This commit is contained in:
Ajay Ramachandran
2020-08-27 21:35:06 -04:00
committed by GitHub
3 changed files with 8 additions and 5 deletions

View File

@@ -112,6 +112,9 @@
"openPopup": { "openPopup": {
"message": "Open SponsorBlock Popup" "message": "Open SponsorBlock Popup"
}, },
"closePopup": {
"message": "Close Popup"
},
"SubmitTimes": { "SubmitTimes": {
"message": "Submit Segments" "message": "Submit Segments"
}, },

View File

@@ -1243,7 +1243,7 @@ function openInfoMenu() {
//close button //close button
let closeButton = document.createElement("div"); let closeButton = document.createElement("div");
closeButton.innerText = "Close Popup"; closeButton.innerText = chrome.i18n.getMessage("closePopup");
closeButton.classList.add("smallLink"); closeButton.classList.add("smallLink");
closeButton.setAttribute("align", "center"); closeButton.setAttribute("align", "center");
closeButton.addEventListener("click", closeInfoMenu); closeButton.addEventListener("click", closeInfoMenu);

View File

@@ -392,7 +392,7 @@ async function runThePopup(messageListener?: MessageListener) {
extraInfo = " (" + chrome.i18n.getMessage("hiddenDueToDuration") + ")"; extraInfo = " (" + chrome.i18n.getMessage("hiddenDueToDuration") + ")";
} }
sponsorTimeButton.innerText = getFormattedTime(request.sponsorTimes[i].segment[0]) + " to " + getFormattedTime(request.sponsorTimes[i].segment[1]) + extraInfo; sponsorTimeButton.innerText = getFormattedTime(request.sponsorTimes[i].segment[0]) + " " + chrome.i18n.getMessage("to") + " " + getFormattedTime(request.sponsorTimes[i].segment[1]) + extraInfo;
let votingButtons = document.createElement("div"); let votingButtons = document.createElement("div");
@@ -448,7 +448,7 @@ async function runThePopup(messageListener?: MessageListener) {
let timeMessage = getFormattedTime(sponsorTimes[i].segment[s]); let timeMessage = getFormattedTime(sponsorTimes[i].segment[s]);
//if this is an end time //if this is an end time
if (s == 1) { if (s == 1) {
timeMessage = " to " + timeMessage; timeMessage = " " + chrome.i18n.getMessage("to") + " " + timeMessage;
} else if (i > 0) { } else if (i > 0) {
//add commas if necessary //add commas if necessary
timeMessage = ", " + timeMessage; timeMessage = ", " + timeMessage;
@@ -505,7 +505,7 @@ async function runThePopup(messageListener?: MessageListener) {
let timeMessage = getFormattedTime(sponsorTimes[i][s]); let timeMessage = getFormattedTime(sponsorTimes[i][s]);
//if this is an end time //if this is an end time
if (s == 1) { if (s == 1) {
timeMessage = " to " + timeMessage; timeMessage = " " + chrome.i18n.getMessage("to") + " " + timeMessage;
} else if (i > 0) { } else if (i > 0) {
//add commas if necessary //add commas if necessary
timeMessage = timeMessage; timeMessage = timeMessage;
@@ -614,7 +614,7 @@ async function runThePopup(messageListener?: MessageListener) {
colonText.innerText = ":"; colonText.innerText = ":";
let toText = document.createElement("span"); let toText = document.createElement("span");
toText.innerText = " to "; toText.innerText = " " + chrome.i18n.getMessage("to") + " ";
//remove all children to replace //remove all children to replace
while (sponsorTimeContainer.firstChild) { while (sponsorTimeContainer.firstChild) {