From cc65dea4c51393b91312b3ab872958ad5960eab8 Mon Sep 17 00:00:00 2001 From: Maxim Date: Thu, 27 Aug 2020 23:53:53 +0500 Subject: [PATCH 1/6] Missing i18n strings for " to " between timecodes --- src/popup.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/popup.ts b/src/popup.ts index 678fb0e3..85f46af8 100644 --- a/src/popup.ts +++ b/src/popup.ts @@ -392,7 +392,7 @@ async function runThePopup(messageListener?: MessageListener) { extraInfo = " (" + chrome.i18n.getMessage("hiddenDueToDuration") + ")"; } - sponsorTimeButton.innerText = getFormattedTime(request.sponsorTimes[i].segment[0]) + " to " + getFormattedTime(request.sponsorTimes[i].segment[1]) + extraInfo; + sponsorTimeButton.innerText = getFormattedTime(request.sponsorTimes[i].segment[0]) + " " + chrome.i18n.getMessage("to") + " " + getFormattedTime(request.sponsorTimes[i].segment[1]) + extraInfo; let votingButtons = document.createElement("div"); @@ -448,7 +448,7 @@ async function runThePopup(messageListener?: MessageListener) { let timeMessage = getFormattedTime(sponsorTimes[i].segment[s]); //if this is an end time if (s == 1) { - timeMessage = " to " + timeMessage; + timeMessage = " " + chrome.i18n.getMessage("to") + " " + timeMessage; } else if (i > 0) { //add commas if necessary timeMessage = ", " + timeMessage; @@ -505,7 +505,7 @@ async function runThePopup(messageListener?: MessageListener) { let timeMessage = getFormattedTime(sponsorTimes[i][s]); //if this is an end time if (s == 1) { - timeMessage = " to " + timeMessage; + timeMessage = " " + chrome.i18n.getMessage("to") + " " + timeMessage; } else if (i > 0) { //add commas if necessary timeMessage = timeMessage; @@ -614,7 +614,7 @@ async function runThePopup(messageListener?: MessageListener) { colonText.innerText = ":"; let toText = document.createElement("span"); - toText.innerText = " to "; + toText.innerText = " " + chrome.i18n.getMessage("to") + " "; //remove all children to replace while (sponsorTimeContainer.firstChild) { From 5cb6f9335ab376c62740784e4221740e76aedd6f Mon Sep 17 00:00:00 2001 From: Maxim Date: Thu, 27 Aug 2020 23:58:13 +0500 Subject: [PATCH 2/6] closePopup message --- public/_locales/en/messages.json | 3 +++ 1 file changed, 3 insertions(+) diff --git a/public/_locales/en/messages.json b/public/_locales/en/messages.json index 7f26105a..3ae46303 100644 --- a/public/_locales/en/messages.json +++ b/public/_locales/en/messages.json @@ -112,6 +112,9 @@ "openPopup": { "message": "Open SponsorBlock Popup" }, + "closePopup": { + "message": "Close Popup" + }, "SubmitTimes": { "message": "Submit Segments" }, From 0f8df07fe036d55c5d3b7df064e01b4896a7b20e Mon Sep 17 00:00:00 2001 From: Maxim Date: Fri, 28 Aug 2020 00:00:08 +0500 Subject: [PATCH 3/6] Localized "Close Popup" string --- src/content.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/content.ts b/src/content.ts index 8c761ecc..7f75ada0 100644 --- a/src/content.ts +++ b/src/content.ts @@ -1243,7 +1243,7 @@ function openInfoMenu() { //close button let closeButton = document.createElement("div"); - closeButton.innerText = "Close Popup"; + closeButton.innerText = chrome.i18n.getMessage("closePopup"); closeButton.classList.add("smallLink"); closeButton.setAttribute("align", "center"); closeButton.addEventListener("click", closeInfoMenu); From 2f2a4e70b7e4ed7334fbb0eec9fb0f341de0e6d7 Mon Sep 17 00:00:00 2001 From: Maxim Date: Fri, 28 Aug 2020 00:05:09 +0500 Subject: [PATCH 4/6] Added sponsorEditingMoved --- public/_locales/en/messages.json | 3 +++ 1 file changed, 3 insertions(+) diff --git a/public/_locales/en/messages.json b/public/_locales/en/messages.json index 3ae46303..eeba6fbf 100644 --- a/public/_locales/en/messages.json +++ b/public/_locales/en/messages.json @@ -79,6 +79,9 @@ "sponsor404": { "message": "No segments found" }, + "sponsorEditingMoved": { + "message": "Sponsor Editing has been moved and will appear after you click submit" + }, "sponsorStart": { "message": "Segment Starts Now" }, From 8c217746bb6263983f2e9db0df477c058422968b Mon Sep 17 00:00:00 2001 From: Maxim Date: Fri, 28 Aug 2020 00:05:50 +0500 Subject: [PATCH 5/6] Localized Sponsor editing string --- public/popup.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/public/popup.html b/public/popup.html index a84673a4..5997ce1d 100644 --- a/public/popup.html +++ b/public/popup.html @@ -38,7 +38,7 @@ __MSG_popupHint__