From cb7262962ccbba3809d1f871605989fd12d7eb3c Mon Sep 17 00:00:00 2001 From: philippe44 Date: Wed, 15 Jan 2020 23:26:43 -0800 Subject: [PATCH] flip correction :-) --- components/display/tarablessd1306/ssd1306.c | 2 +- plugin/SqueezeESP32/Graphics.pm | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/components/display/tarablessd1306/ssd1306.c b/components/display/tarablessd1306/ssd1306.c index c94fed83..343652cd 100644 --- a/components/display/tarablessd1306/ssd1306.c +++ b/components/display/tarablessd1306/ssd1306.c @@ -209,7 +209,7 @@ static bool SSD1306_Init( struct SSD1306_Device* DeviceHandle, int Width, int He SSD1306_HWReset( DeviceHandle ); /* Init sequence according to SSD1306.pdf */ - SSD1306_SetMuxRatio( DeviceHandle, 0x3F ); + SSD1306_SetMuxRatio( DeviceHandle, Height - 1 ); SSD1306_SetDisplayOffset( DeviceHandle, 0x00 ); SSD1306_SetDisplayStartLine( DeviceHandle, 0 ); SSD1306_SetHFlip( DeviceHandle, false ); diff --git a/plugin/SqueezeESP32/Graphics.pm b/plugin/SqueezeESP32/Graphics.pm index dadd335a..03f3aed5 100644 --- a/plugin/SqueezeESP32/Graphics.pm +++ b/plugin/SqueezeESP32/Graphics.pm @@ -45,6 +45,12 @@ sub nmodes { return $#modes; } +# I don't think LMS renderer handles properly screens other than 32 pixels. It +# seems that all we get is a 32 pixel-tall data with anything else padded to 0 +# i.e. if we try 64 pixels height, bytes 0..3 and 4..7 will contains the same +# pattern than the 32 pixels version, where one would have expected bytes 4..7 +# to be empty + =comment sub bytesPerColumn { return 4;