From 90ee59754d1ee489d3c0391b982414516a20baed Mon Sep 17 00:00:00 2001 From: Philippe G Date: Sat, 5 Dec 2020 16:10:53 -0800 Subject: [PATCH] discover buffer potential overflow --- components/squeezelite/slimproto.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/components/squeezelite/slimproto.c b/components/squeezelite/slimproto.c index 8dd05b54..59f79d53 100644 --- a/components/squeezelite/slimproto.c +++ b/components/squeezelite/slimproto.c @@ -822,14 +822,14 @@ in_addr_t discover_server(char *default_server, int max) { memset(&s, 0, sizeof(s)); if (sendto(disc_sock, buf, len, 0, (struct sockaddr *)&d, sizeof(d)) < 0) { - LOG_INFO("error sending disovery"); + LOG_INFO("error sending discovery"); } if (poll(&pollinfo, 1, 5000) == 1) { - char readbuf[32], *p; + char readbuf[64], *p; socklen_t slen = sizeof(s); - memset(readbuf, 0, 32); - recvfrom(disc_sock, readbuf, 32 - 1, 0, (struct sockaddr *)&s, &slen); + memset(readbuf, 0, sizeof(readbuf)); + recvfrom(disc_sock, readbuf, sizeof(readbuf) - 1, 0, (struct sockaddr *)&s, &slen); LOG_INFO("got response from: %s:%d", inet_ntoa(s.sin_addr), ntohs(s.sin_port)); if ((p = strstr(readbuf, port_d)) != NULL) {