fixed cspot crash when switching with LMS

This commit is contained in:
Philippe G
2021-12-25 23:05:53 -08:00
parent 1422003271
commit 676acbdbc2
5 changed files with 13 additions and 4 deletions

View File

@@ -103,6 +103,8 @@ namespace bell
//delete m_queue.front();
m_queue.pop();
}
lk.unlock();
m_cv.notify_one();
}
/// <summary> Check queue in forced exit state. </summary>
bool isExit() const

View File

@@ -59,6 +59,7 @@ private:
std::map<uint64_t, mercuryCallback> callbacks;
std::mutex reconnectionMutex;
std::mutex runningMutex;
std::mutex stopMutex;
std::map<std::string, mercuryCallback> subscriptions;
std::unique_ptr<Session> session;
std::shared_ptr<LoginBlob> lastAuthBlob;

View File

@@ -45,8 +45,8 @@ void AudioChunkManager::close() {
}
void AudioChunkManager::runTask() {
this->isRunning = true;
std::scoped_lock lock(this->runningMutex);
this->isRunning = true;
while (isRunning) {
std::pair<std::vector<uint8_t>, bool> audioPair;
if (this->audioChunkDataQueue.wtpop(audioPair, 100)) {

View File

@@ -29,6 +29,8 @@ MercuryManager::MercuryManager(std::unique_ptr<Session> session): bell::Task("me
bool MercuryManager::timeoutHandler()
{
if (!isRunning) return true;
auto currentTimestamp = timeProvider->getSyncedTimestamp();
if (this->lastRequestTimestamp != -1 && currentTimestamp - this->lastRequestTimestamp > AUDIOCHUNK_TIMEOUT_MS)
@@ -189,10 +191,11 @@ void MercuryManager::runTask()
}
void MercuryManager::stop() {
std::scoped_lock stop(this->stopMutex);
CSPOT_LOG(debug, "Stopping mercury manager");
isRunning = false;
audioChunkManager->close();
std::scoped_lock lock(audioChunkManager->runningMutex, this->runningMutex);
std::scoped_lock lock(this->runningMutex);
CSPOT_LOG(debug, "mercury stopped");
}
@@ -274,6 +277,8 @@ void MercuryManager::handleQueue()
{
this->updateQueue();
}
std::scoped_lock lock(this->stopMutex);
}
uint64_t MercuryManager::execute(MercuryType method, std::string uri, mercuryCallback& callback, mercuryCallback& subscription, mercuryParts& payload)

View File

@@ -55,6 +55,7 @@ void SpircController::disconnect(void) {
player->cancelCurrentTrack();
state->setActive(false);
notify();
// Send the event at the end at it might be a last gasp
sendEvent(CSpotEventType::DISC);
}