Mirror/squeezelite-esp32
1
0
Fork 0
mirror of https://github.com/sle118/squeezelite-esp32.git synced 2025-12-06 11:36:59 +03:00
Code Issues Packages Projects Releases Wiki Activity

add checks for grfX handlers to prevent divide-by-zero with slimproto (#424)

Browse Source 
Thank you!
This commit is contained in:
wizmo2
2024-06-07 18:19:33 -04:00
committed by GitHub
parent 38d28ae8c4
commit 40a698e2f1
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
components/squeezelite/displayer.c
View File

@@ -687,6 +687,7 @@ void draw_VU(struct GDS_Device * display, int level, int x, int y, int width, bo
static void grfe_handler( u8_t *data, int len) { static void grfe_handler( u8_t *data, int len) {
struct grfe_packet *pkt = (struct grfe_packet*) data; struct grfe_packet *pkt = (struct grfe_packet*) data;
GDS_CHECK_FOR_DEVICE(display,return);
// we don't support transition, simply claim we're done // we don't support transition, simply claim we're done
if (pkt->transition != 'c') { if (pkt->transition != 'c') {
LOG_INFO("Transition %c requested with offset %hu, param %d", pkt->transition, pkt->offset, pkt->param); LOG_INFO("Transition %c requested with offset %hu, param %d", pkt->transition, pkt->offset, pkt->param);
@@ -773,7 +774,8 @@ static void grfs_handler(u8_t *data, int len) {
htons(pkt->width), // last column of animation that contains a "full" screen htons(pkt->width), // last column of animation that contains a "full" screen
htons(pkt->offset) // offset if multiple packets are sent htons(pkt->offset) // offset if multiple packets are sent
); );
GDS_CHECK_FOR_DEVICE(display,return);
// new grfs frame, build scroller info // new grfs frame, build scroller info
if (!offset) { if (!offset) {
// use the display as a general lock // use the display as a general lock
@@ -820,6 +822,7 @@ static void grfg_handler(u8_t *data, int len) {
LOG_DEBUG("gfrg s:%hu w:%hu (len:%u)", htons(pkt->screen), htons(pkt->width), len); LOG_DEBUG("gfrg s:%hu w:%hu (len:%u)", htons(pkt->screen), htons(pkt->width), len);
GDS_CHECK_FOR_DEVICE(display,return);
// full screen artwork or for small screen, visu has priority when full screen // full screen artwork or for small screen, visu has priority when full screen
if (((visu.mode & VISU_ESP32) && !visu.col && visu.row < displayer.height) || artwork.full) { if (((visu.mode & VISU_ESP32) && !visu.col && visu.row < displayer.height) || artwork.full) {
return; return;
@@ -864,6 +867,7 @@ static void grfa_handler(u8_t *data, int len) {
int offset = htonl(pkt->offset); int offset = htonl(pkt->offset);
int length = htonl(pkt->length); int length = htonl(pkt->length);
GDS_CHECK_FOR_DEVICE(display,return);
// when using full screen visualizer on small screen there is a brief overlay // when using full screen visualizer on small screen there is a brief overlay
artwork.enable = (length != 0); artwork.enable = (length != 0);