Strictest / tests / minor improvements

src/crypt/getDomainData.ts

@@ -1,14 +1,24 @@
-import { type SupportedChainId } from '../types';
+import type { SupportedChainId } from '../types';
 import eip712DomainData from '../config/eip712DomainData.json';
 import eip712DomainSchema from '../config/schemas/eip712DomainSchema';
 
 const EIP712Domain = eip712DomainSchema.parse(eip712DomainData);
 
+function removeUndefined<T>(obj: Record<string, T | undefined>) {
+  const newObj: Partial<Record<string, T>> = {};
+  for (const [key, value] of Object.entries(obj)) {
+    if (value !== undefined) {
+      newObj[key] = value;
+    }
+  }
+  return newObj;
+}
+
 /**
  * See {@link https://eips.ethereum.org/EIPS/eip-712#definition-of-domainseparator}
  */
 const getDomainData = (chainId: SupportedChainId) => ({
-  ...EIP712Domain,
+  ...removeUndefined(EIP712Domain),
   chainId,
 });
 

src/crypt/hashCFDOrder.ts

@@ -1,5 +1,5 @@
 import { ethers } from 'ethers';
-import { type CFDOrder } from '../types';
+import type { CFDOrder } from '../types';
 
 const hashCFDOrder = (order: CFDOrder) => ethers.utils.solidityKeccak256(
   [

src/crypt/hashOrder.ts

@@ -1,5 +1,5 @@
 import { ethers } from 'ethers';
-import { type Order } from '../types';
+import type { Order } from '../types';
 
 const hashOrder = (order: Order) => ethers.utils.solidityKeccak256(
   [

src/crypt/signCFDOrder.ts

@@ -1,9 +1,9 @@
-import { type TypedDataSigner } from '@ethersproject/abstract-signer';
+import type { TypedDataSigner } from '@ethersproject/abstract-signer';
 import BigNumber from 'bignumber.js';
-import { type ethers } from 'ethers';
+import type { ethers } from 'ethers';
 import { joinSignature, splitSignature } from 'ethers/lib/utils';
 import { INTERNAL_ORION_PRECISION } from '../constants';
-import { type CFDOrder, type SignedCFDOrder, type SupportedChainId } from '../types';
+import type { CFDOrder, SignedCFDOrder, SupportedChainId } from '../types';
 import normalizeNumber from '../utils/normalizeNumber';
 import getDomainData from './getDomainData';
 import signCFDOrderPersonal from './signCFDOrderPersonal';

src/crypt/signCFDOrderPersonal.ts

@@ -1,5 +1,5 @@
 import { ethers } from 'ethers';
-import { type CFDOrder } from '../types';
+import type { CFDOrder } from '../types';
 
 const { arrayify, joinSignature, splitSignature } = ethers.utils;
 

src/crypt/signCancelOrder.ts

@@ -1,8 +1,8 @@
-import { type TypedDataSigner } from '@ethersproject/abstract-signer';
-import { type ethers } from 'ethers';
+import type { TypedDataSigner } from '@ethersproject/abstract-signer';
+import type { ethers } from 'ethers';
 import { joinSignature, splitSignature } from 'ethers/lib/utils';
 import CANCEL_ORDER_TYPES from '../constants/cancelOrderTypes';
-import { type CancelOrderRequest, type SignedCancelOrderRequest, type SupportedChainId } from '../types';
+import type { CancelOrderRequest, SignedCancelOrderRequest, SupportedChainId } from '../types';
 import getDomainData from './getDomainData';
 import signCancelOrderPersonal from './signCancelOrderPersonal';
 

src/crypt/signCancelOrderPersonal.ts

@@ -1,6 +1,6 @@
 import { ethers } from 'ethers';
 import { arrayify, joinSignature, splitSignature } from 'ethers/lib/utils';
-import { type CancelOrderRequest } from '../types';
+import type { CancelOrderRequest } from '../types';
 
 const signCancelOrderPersonal = async (
   cancelOrderRequest: CancelOrderRequest,

src/crypt/signOrder.ts

@@ -1,10 +1,10 @@
-import { type TypedDataSigner } from '@ethersproject/abstract-signer';
+import type { TypedDataSigner } from '@ethersproject/abstract-signer';
 import BigNumber from 'bignumber.js';
-import { type ethers } from 'ethers';
+import type { ethers } from 'ethers';
 import { joinSignature, splitSignature } from 'ethers/lib/utils';
 import { INTERNAL_ORION_PRECISION } from '../constants';
 import ORDER_TYPES from '../constants/orderTypes';
-import { type Order, type SignedOrder, type SupportedChainId } from '../types';
+import type { Order, SignedOrder, SupportedChainId } from '../types';
 import normalizeNumber from '../utils/normalizeNumber';
 import getDomainData from './getDomainData';
 import hashOrder from './hashOrder';

src/crypt/signOrderPersonal.ts

@@ -1,5 +1,5 @@
 import { ethers } from 'ethers';
-import { type Order } from '../types';
+import type { Order } from '../types';
 
 const { arrayify, joinSignature, splitSignature } = ethers.utils;