Impl

src/OrionUnit/Exchange/deposit.ts

@@ -4,7 +4,7 @@ import { ethers } from 'ethers';
 import { Exchange__factory } from '@orionprotocol/contracts';
 import getBalances from '../../utils/getBalances';
 import BalanceGuard from '../../BalanceGuard';
-import OrionUnit from '..';
+import type OrionUnit from '..';
 import { utils } from '../..';
 import {
   DEPOSIT_ERC20_GAS_LIMIT, DEPOSIT_ETH_GAS_LIMIT, INTERNAL_ORION_PRECISION, NATIVE_CURRENCY_PRECISION,
@@ -13,11 +13,11 @@ import { normalizeNumber } from '../../utils';
 import getNativeCryptocurrency from '../../utils/getNativeCryptocurrency';
 import simpleFetch from '../../simpleFetch';
 
-export type DepositParams = {
-  asset: string,
-  amount: BigNumber.Value,
-  signer: ethers.Signer,
-  orionUnit: OrionUnit,
+export interface DepositParams {
+  asset: string
+  amount: BigNumber.Value
+  signer: ethers.Signer
+  orionUnit: OrionUnit
 }
 
 export default async function deposit({
@@ -29,8 +29,8 @@ export default async function deposit({
   if (asset === '') throw new Error('Asset can not be empty');
 
   const amountBN = new BigNumber(amount);
-  if (amountBN.isNaN()) throw new Error(`Amount '${amount.toString()}' is not a number`);
-  if (amountBN.lte(0)) throw new Error(`Amount '${amount.toString()}' should be greater than 0`);
+  if (amountBN.isNaN()) throw new Error(`Amount '${amountBN.toString()}' is not a number`);
+  if (amountBN.lte(0)) throw new Error(`Amount '${amountBN.toString()}' should be greater than 0`);
 
   const walletAddress = await signer.getAddress();
 
@@ -48,7 +48,7 @@ export default async function deposit({
   const gasPriceWei = await simpleFetch(orionBlockchain.getGasPriceWei)();
 
   const assetAddress = assetToAddress[asset];
-  if (!assetAddress) throw new Error(`Asset '${asset}' not found`);
+  if (assetAddress === undefined) throw new Error(`Asset '${asset}' not found`);
 
   const balances = await getBalances(
     {
@@ -121,7 +121,7 @@ export default async function deposit({
   const txResponse = await provider.sendTransaction(signedTx);
   console.log(`Deposit tx sent: ${txResponse.hash}. Waiting for confirmation...`);
   const txReceipt = await txResponse.wait();
-  if (txReceipt.status) {
+  if (txReceipt.status !== undefined) {
     console.log('Deposit tx confirmed');
   } else {
     console.log('Deposit tx failed');

src/OrionUnit/Exchange/getSwapInfo.ts

@@ -2,23 +2,23 @@ import BigNumber from 'bignumber.js';
 import { ethers } from 'ethers';
 import { utils } from '../..';
 import { NATIVE_CURRENCY_PRECISION, SWAP_THROUGH_ORION_POOL_GAS_LIMIT } from '../../constants';
-import { OrionAggregator } from '../../services/OrionAggregator';
-import { OrionBlockchain } from '../../services/OrionBlockchain';
+import { type OrionAggregator } from '../../services/OrionAggregator';
+import { type OrionBlockchain } from '../../services/OrionBlockchain';
 
 import simpleFetch from '../../simpleFetch';
 import getNativeCryptocurrency from '../../utils/getNativeCryptocurrency';
 
-export type GetSwapInfoParams = {
-  type: 'exactSpend' | 'exactReceive',
-  assetIn: string,
-  assetOut: string,
-  amount: BigNumber.Value,
-  feeAsset: string,
-  orionBlockchain: OrionBlockchain,
+export interface GetSwapInfoParams {
+  type: 'exactSpend' | 'exactReceive'
+  assetIn: string
+  assetOut: string
+  amount: BigNumber.Value
+  feeAsset: string
+  orionBlockchain: OrionBlockchain
   orionAggregator: OrionAggregator
   options?: {
-    instantSettlement?: boolean,
-    poolOnly?: boolean,
+    instantSettlement?: boolean
+    poolOnly?: boolean
   }
 }
 
@@ -38,8 +38,8 @@ export default async function getSwapInfo({
   if (feeAsset === '') throw new Error('Fee asset can not be empty');
 
   const amountBN = new BigNumber(amount);
-  if (amountBN.isNaN()) throw new Error(`Amount '${amount.toString()}' is not a number`);
-  if (amountBN.lte(0)) throw new Error(`Amount '${amount.toString()}' should be greater than 0`);
+  if (amountBN.isNaN()) throw new Error(`Amount '${amountBN.toString()}' is not a number`);
+  if (amountBN.lte(0)) throw new Error(`Amount '${amountBN.toString()}' should be greater than 0`);
 
   const {
     assetToAddress,
@@ -53,17 +53,21 @@ export default async function getSwapInfo({
   const gasPriceGwei = ethers.utils.formatUnits(gasPriceWei, 'gwei').toString();
 
   const assetInAddress = assetToAddress[assetIn];
-  if (!assetInAddress) throw new Error(`Asset '${assetIn}' not found`);
+  if (assetInAddress === undefined) throw new Error(`Asset '${assetIn}' not found`);
   const feeAssetAddress = assetToAddress[feeAsset];
-  if (!feeAssetAddress) throw new Error(`Fee asset '${feeAsset}' not found. Available assets: ${Object.keys(feeAssets).join(', ')}`);
+  if (feeAssetAddress === undefined) {
+    throw new Error(`Fee asset '${feeAsset}' not found. Available assets: ${Object.keys(feeAssets).join(', ')}`);
+  }
 
   const swapInfo = await simpleFetch(orionAggregator.getSwapInfo)(
     type,
     assetIn,
     assetOut,
-    amount.toString(),
+    amountBN.toString(),
     options?.instantSettlement,
-    options?.poolOnly ? 'pools' : undefined,
+    options?.poolOnly !== undefined && options.poolOnly
+      ? 'pools'
+      : undefined,
   );
 
   const { exchanges: swapExchanges } = swapInfo;
@@ -82,13 +86,12 @@ export default async function getSwapInfo({
   // if (swapInfo.orderInfo === null) throw new Error(swapInfo.executionInfo);
 
   let route: 'pool' | 'aggregator';
-  if (options?.poolOnly) {
+  if (options?.poolOnly !== undefined && options.poolOnly) {
     route = 'pool';
   } else if (
-    swapExchanges !== undefined &&
     poolExchangesList.length > 0 &&
     swapExchanges.length === 1 &&
-    firstSwapExchange &&
+    firstSwapExchange !== undefined &&
     poolExchangesList.some((poolExchange) => poolExchange === firstSwapExchange)
   ) {
     route = 'pool';
@@ -112,21 +115,21 @@ export default async function getSwapInfo({
     };
   }
 
-  if (swapInfo.orderInfo) {
+  if (swapInfo.orderInfo != null) {
     const [baseAssetName] = swapInfo.orderInfo.assetPair.split('-');
     if (baseAssetName === undefined) throw new Error('Base asset name is undefined');
     const baseAssetAddress = assetToAddress[baseAssetName];
-    if (!baseAssetAddress) throw new Error(`No asset address for ${baseAssetName}`);
+    if (baseAssetAddress === undefined) throw new Error(`No asset address for ${baseAssetName}`);
 
     // Fee calculation
-    const baseAssetPriceInOrn = pricesInOrn?.[baseAssetAddress];
-    if (!baseAssetPriceInOrn) throw new Error(`Base asset price ${baseAssetName} in ORN not found`);
+    const baseAssetPriceInOrn = pricesInOrn[baseAssetAddress];
+    if (baseAssetPriceInOrn === undefined) throw new Error(`Base asset price ${baseAssetName} in ORN not found`);
     const baseCurrencyPriceInOrn = pricesInOrn[ethers.constants.AddressZero];
-    if (!baseCurrencyPriceInOrn) throw new Error('Base currency price in ORN not found');
+    if (baseCurrencyPriceInOrn === undefined) throw new Error('Base currency price in ORN not found');
     const feeAssetPriceInOrn = pricesInOrn[feeAssetAddress];
-    if (!feeAssetPriceInOrn) throw new Error(`Fee asset price ${feeAsset} in ORN not found`);
-    const feePercent = feeAssets?.[feeAsset];
-    if (!feePercent) throw new Error(`Fee asset ${feeAsset} not available`);
+    if (feeAssetPriceInOrn === undefined) throw new Error(`Fee asset price ${feeAsset} in ORN not found`);
+    const feePercent = feeAssets[feeAsset];
+    if (feePercent === undefined) throw new Error(`Fee asset ${feeAsset} not available`);
 
     const {
       orionFeeInFeeAsset,

src/OrionUnit/Exchange/index.ts

@@ -1,13 +1,13 @@
-import OrionUnit from '..';
-import deposit, { DepositParams } from './deposit';
-import getSwapInfo, { GetSwapInfoParams } from './getSwapInfo';
-import swapMarket, { SwapMarketParams } from './swapMarket';
-import withdraw, { WithdrawParams } from './withdraw';
+import type OrionUnit from '..';
+import deposit, { type DepositParams } from './deposit';
+import getSwapInfo, { type GetSwapInfoParams } from './getSwapInfo';
+import swapMarket, { type Swap, type SwapMarketParams } from './swapMarket';
+import withdraw, { type WithdrawParams } from './withdraw';
 
-type PureSwapMarketParams= Omit<SwapMarketParams, 'orionUnit'>
+type PureSwapMarketParams = Omit<SwapMarketParams, 'orionUnit'>
 type PureDepositParams = Omit<DepositParams, 'orionUnit'>
 type PureWithdrawParams = Omit<WithdrawParams, 'orionUnit'>
-type PureGetSwapMarketInfoParams= Omit<GetSwapInfoParams, 'orionBlockchain' | 'orionAggregator'>
+type PureGetSwapMarketInfoParams = Omit<GetSwapInfoParams, 'orionBlockchain' | 'orionAggregator'>
 
 export default class Exchange {
   private readonly orionUnit: OrionUnit;
@@ -16,7 +16,7 @@ export default class Exchange {
     this.orionUnit = orionUnit;
   }
 
-  public swapMarket(params: PureSwapMarketParams) {
+  public swapMarket(params: PureSwapMarketParams): Promise<Swap> {
     return swapMarket({
       ...params,
       orionUnit: this.orionUnit,

src/OrionUnit/Exchange/swapMarket.ts

@@ -5,43 +5,43 @@ import { Exchange__factory } from '@orionprotocol/contracts';
 import getBalances from '../../utils/getBalances';
 import BalanceGuard from '../../BalanceGuard';
 import getAvailableSources from '../../utils/getAvailableFundsSources';
-import OrionUnit from '..';
+import type OrionUnit from '..';
 import { crypt, utils } from '../..';
 import { INTERNAL_ORION_PRECISION, NATIVE_CURRENCY_PRECISION, SWAP_THROUGH_ORION_POOL_GAS_LIMIT } from '../../constants';
 import getNativeCryptocurrency from '../../utils/getNativeCryptocurrency';
 import simpleFetch from '../../simpleFetch';
 
-export type SwapMarketParams = {
-  type: 'exactSpend' | 'exactReceive',
-  assetIn: string,
-  assetOut: string,
-  amount: BigNumber.Value,
-  feeAsset: string,
-  slippagePercent: BigNumber.Value,
-  signer: ethers.Signer,
-  orionUnit: OrionUnit,
+export interface SwapMarketParams {
+  type: 'exactSpend' | 'exactReceive'
+  assetIn: string
+  assetOut: string
+  amount: BigNumber.Value
+  feeAsset: string
+  slippagePercent: BigNumber.Value
+  signer: ethers.Signer
+  orionUnit: OrionUnit
   options?: {
-    poolOnly?: boolean,
-    instantSettlement?: boolean,
-    logger?: (message: string) => void,
-    autoApprove?: boolean,
+    poolOnly?: boolean
+    instantSettlement?: boolean
+    logger?: (message: string) => void
+    autoApprove?: boolean
     developer?: {
-      route?: 'aggregator' | 'pool',
+      route?: 'aggregator' | 'pool'
     }
   }
 }
 
-type AggregatorOrder = {
+interface AggregatorOrder {
   through: 'aggregator'
-  id: string,
+  id: string
 }
 
-type PoolSwap = {
+interface PoolSwap {
   through: 'orion_pool'
-  txHash: string,
+  txHash: string
 }
 
-type Swap = AggregatorOrder | PoolSwap;
+export type Swap = AggregatorOrder | PoolSwap;
 
 export default async function swapMarket({
   type,
@@ -54,7 +54,7 @@ export default async function swapMarket({
   orionUnit,
   options,
 }: SwapMarketParams): Promise<Swap> {
-  if (options?.developer) options?.logger?.('YOU SPECIFIED A DEVELOPER OPTIONS. BE CAREFUL!');
+  if ((options?.developer) != null) options.logger?.('YOU SPECIFIED A DEVELOPER OPTIONS. BE CAREFUL!');
   if (amount === '') throw new Error('Amount can not be empty');
   if (assetIn === '') throw new Error('AssetIn can not be empty');
   if (assetOut === '') throw new Error('AssetOut can not be empty');
@@ -93,9 +93,9 @@ export default async function swapMarket({
   const gasPriceGwei = ethers.utils.formatUnits(gasPriceWei, 'gwei').toString();
 
   const assetInAddress = assetToAddress[assetIn];
-  if (!assetInAddress) throw new Error(`Asset '${assetIn}' not found`);
+  if (assetInAddress === undefined) throw new Error(`Asset '${assetIn}' not found`);
   const feeAssetAddress = assetToAddress[feeAsset];
-  if (!feeAssetAddress) throw new Error(`Fee asset '${feeAsset}' not found. Available assets: ${Object.keys(feeAssets).join(', ')}`);
+  if (feeAssetAddress === undefined) throw new Error(`Fee asset '${feeAsset}' not found. Available assets: ${Object.keys(feeAssets).join(', ')}`);
 
   const balances = await getBalances(
     {
@@ -124,16 +124,18 @@ export default async function swapMarket({
     type,
     assetIn,
     assetOut,
-    amount.toString(),
+    amountBN.toString(),
     options?.instantSettlement,
-    options?.poolOnly ? 'pools' : undefined,
+    options?.poolOnly !== undefined && options.poolOnly
+      ? 'pools'
+      : undefined,
   );
 
   const { exchanges: swapExchanges } = swapInfo;
 
   const [firstSwapExchange] = swapExchanges;
 
-  if (swapExchanges) options?.logger?.(`Swap exchanges: ${swapExchanges.join(', ')}`);
+  if (swapExchanges.length > 0) options?.logger?.(`Swap exchanges: ${swapExchanges.join(', ')}`);
 
   if (swapInfo.type === 'exactReceive' && amountBN.lt(swapInfo.minAmountOut)) {
     throw new Error(`Amount is too low. Min amountOut is ${swapInfo.minAmountOut} ${assetOut}`);
@@ -150,8 +152,6 @@ export default async function swapMarket({
   if (quoteAssetName === undefined) throw new Error('Quote asset name is undefined');
 
   const pairConfig = await simpleFetch(orionAggregator.getPairConfig)(`${baseAssetName}-${quoteAssetName}`);
-  if (!pairConfig) throw new Error(`Pair config ${baseAssetName}-${quoteAssetName} not found`);
-
   const qtyPrecisionBN = new BigNumber(pairConfig.qtyPrecision);
   const qtyDecimalPlaces = amountBN.dp();
 
@@ -165,15 +165,14 @@ export default async function swapMarket({
 
   if (options?.developer?.route !== undefined) {
     route = options.developer.route;
-    options?.logger?.(`Swap is through ${route} (because route forced to ${route})`);
-  } else if (options?.poolOnly) {
-    options?.logger?.('Swap is through pool (because "poolOnly" option is true)');
+    options.logger?.(`Swap is through ${route} (because route forced to ${route})`);
+  } else if (options?.poolOnly !== undefined && options.poolOnly) {
+    options.logger?.('Swap is through pool (because "poolOnly" option is true)');
     route = 'pool';
   } else if (
-    swapExchanges !== undefined &&
     poolExchangesList.length > 0 &&
     swapExchanges.length === 1 &&
-    firstSwapExchange &&
+    firstSwapExchange !== undefined &&
     poolExchangesList.some((poolExchange) => poolExchange === firstSwapExchange)
   ) {
     options?.logger?.(`Swap is through pool [via ${firstSwapExchange}] (detected by "exchanges" field)`);
@@ -184,14 +183,14 @@ export default async function swapMarket({
 
   if (route === 'pool') {
     let factoryAddress: string | undefined;
-    if (factories && firstSwapExchange) {
-      factoryAddress = factories?.[firstSwapExchange];
-      if (factoryAddress) options?.logger?.(`Factory address is ${factoryAddress}. Exchange is ${firstSwapExchange}`);
+    if ((factories != null) && firstSwapExchange !== undefined) {
+      factoryAddress = factories[firstSwapExchange];
+      if (factoryAddress !== undefined) options?.logger?.(`Factory address is ${factoryAddress}. Exchange is ${firstSwapExchange}`);
     }
 
     const pathAddresses = swapInfo.path.map((name) => {
-      const assetAddress = assetToAddress?.[name];
-      if (!assetAddress) throw new Error(`No asset address for ${name}`);
+      const assetAddress = assetToAddress[name];
+      if (assetAddress === undefined) throw new Error(`No asset address for ${name}`);
       return assetAddress;
     });
 
@@ -229,7 +228,9 @@ export default async function swapMarket({
     const unsignedSwapThroughOrionPoolTx = await exchangeContract.populateTransaction.swapThroughOrionPool(
       amountSpendBlockchainParam,
       amountReceiveBlockchainParam,
-      factoryAddress ? [factoryAddress, ...pathAddresses] : pathAddresses,
+      factoryAddress !== undefined
+        ? [factoryAddress, ...pathAddresses]
+        : pathAddresses,
       type === 'exactSpend',
     );
 
@@ -241,7 +242,7 @@ export default async function swapMarket({
 
     let value = new BigNumber(0);
     const denormalizedAssetInExchangeBalance = balances[assetIn]?.exchange;
-    if (!denormalizedAssetInExchangeBalance) throw new Error(`Asset '${assetIn}' exchange balance is not found`);
+    if (denormalizedAssetInExchangeBalance == null) throw new Error(`Asset '${assetIn}' exchange balance is not found`);
     if (assetIn === nativeCryptocurrency && amountSpendBN.gt(denormalizedAssetInExchangeBalance)) {
       value = amountSpendBN.minus(denormalizedAssetInExchangeBalance);
     }
@@ -305,9 +306,9 @@ export default async function swapMarket({
       .toString();
 
   const baseAssetAddress = assetToAddress[baseAssetName];
-  if (!baseAssetAddress) throw new Error(`No asset address for ${baseAssetName}`);
+  if (baseAssetAddress === undefined) throw new Error(`No asset address for ${baseAssetName}`);
   const quoteAssetAddress = assetToAddress[quoteAssetName];
-  if (!quoteAssetAddress) throw new Error(`No asset address for ${quoteAssetName}`);
+  if (quoteAssetAddress === undefined) throw new Error(`No asset address for ${quoteAssetName}`);
 
   const safePriceWithAppliedPrecision = new BigNumber(safePriceWithDeviation)
     .decimalPlaces(
@@ -331,14 +332,14 @@ export default async function swapMarket({
   });
 
   // Fee calculation
-  const baseAssetPriceInOrn = pricesInOrn?.[baseAssetAddress];
-  if (!baseAssetPriceInOrn) throw new Error(`Base asset price ${baseAssetName} in ORN not found`);
+  const baseAssetPriceInOrn = pricesInOrn[baseAssetAddress];
+  if (baseAssetPriceInOrn === undefined) throw new Error(`Base asset price ${baseAssetName} in ORN not found`);
   const baseCurrencyPriceInOrn = pricesInOrn[ethers.constants.AddressZero];
-  if (!baseCurrencyPriceInOrn) throw new Error('Base currency price in ORN not found');
+  if (baseCurrencyPriceInOrn === undefined) throw new Error('Base currency price in ORN not found');
   const feeAssetPriceInOrn = pricesInOrn[feeAssetAddress];
-  if (!feeAssetPriceInOrn) throw new Error(`Fee asset price ${feeAsset} in ORN not found`);
-  const feePercent = feeAssets?.[feeAsset];
-  if (!feePercent) throw new Error(`Fee asset ${feeAsset} not available`);
+  if (feeAssetPriceInOrn === undefined) throw new Error(`Fee asset price ${feeAsset} in ORN not found`);
+  const feePercent = feeAssets[feeAsset];
+  if (feePercent === undefined) throw new Error(`Fee asset ${feeAsset} not available`);
 
   const { orionFeeInFeeAsset, networkFeeInFeeAsset, totalFeeInFeeAsset } = utils.calculateFeeInFeeAsset(
     swapInfo.orderInfo.amount,

src/OrionUnit/Exchange/withdraw.ts

@@ -4,7 +4,7 @@ import { ethers } from 'ethers';
 import { Exchange__factory } from '@orionprotocol/contracts';
 import getBalances from '../../utils/getBalances';
 import BalanceGuard from '../../BalanceGuard';
-import OrionUnit from '..';
+import type OrionUnit from '..';
 import { utils } from '../..';
 import {
   INTERNAL_ORION_PRECISION, NATIVE_CURRENCY_PRECISION, WITHDRAW_GAS_LIMIT,
@@ -13,11 +13,11 @@ import { normalizeNumber } from '../../utils';
 import getNativeCryptocurrency from '../../utils/getNativeCryptocurrency';
 import simpleFetch from '../../simpleFetch';
 
-export type WithdrawParams = {
-  asset: string,
-  amount: BigNumber.Value,
-  signer: ethers.Signer,
-  orionUnit: OrionUnit,
+export interface WithdrawParams {
+  asset: string
+  amount: BigNumber.Value
+  signer: ethers.Signer
+  orionUnit: OrionUnit
 }
 
 export default async function withdraw({
@@ -29,8 +29,8 @@ export default async function withdraw({
   if (asset === '') throw new Error('Asset can not be empty');
 
   const amountBN = new BigNumber(amount);
-  if (amountBN.isNaN()) throw new Error(`Amount '${amount.toString()}' is not a number`);
-  if (amountBN.lte(0)) throw new Error(`Amount '${amount.toString()}' should be greater than 0`);
+  if (amountBN.isNaN()) throw new Error(`Amount '${amountBN.toString()}' is not a number`);
+  if (amountBN.lte(0)) throw new Error(`Amount '${amountBN.toString()}' should be greater than 0`);
 
   const walletAddress = await signer.getAddress();
 
@@ -47,7 +47,7 @@ export default async function withdraw({
   const gasPriceWei = await simpleFetch(orionBlockchain.getGasPriceWei)();
 
   const assetAddress = assetToAddress[asset];
-  if (!assetAddress) throw new Error(`Asset '${asset}' not found`);
+  if (assetAddress === undefined) throw new Error(`Asset '${asset}' not found`);
 
   const balances = await getBalances(
     {
@@ -76,7 +76,7 @@ export default async function withdraw({
       name: asset,
       address: assetAddress,
     },
-    amount: amount.toString(),
+    amount: amountBN.toString(),
     sources: ['exchange'],
   });
 
@@ -112,7 +112,7 @@ export default async function withdraw({
   const txResponse = await provider.sendTransaction(signedTx);
   console.log(`Withdraw tx sent: ${txResponse.hash}. Waiting for confirmation...`);
   const txReceipt = await txResponse.wait();
-  if (txReceipt.status) {
+  if (txReceipt.status !== undefined) {
     console.log('Withdraw tx confirmed');
   } else {
     console.log('Withdraw tx failed');

src/OrionUnit/FarmingManager/index.ts

@@ -1,7 +1,7 @@
 import { Exchange__factory, IUniswapV2Pair__factory, IUniswapV2Router__factory } from '@orionprotocol/contracts';
 import BigNumber from 'bignumber.js';
 import { ethers } from 'ethers';
-import OrionUnit from '..';
+import type OrionUnit from '..';
 import BalanceGuard from '../../BalanceGuard';
 import { ADD_LIQUIDITY_GAS_LIMIT, INTERNAL_ORION_PRECISION, NATIVE_CURRENCY_PRECISION } from '../../constants';
 import simpleFetch from '../../simpleFetch';
@@ -11,15 +11,15 @@ import getNativeCryptocurrency from '../../utils/getNativeCryptocurrency';
 
 const ADD_LIQUIDITY_SLIPPAGE = 0.05;
 
-export type AddLiquidityParams = {
-  poolName: string,
-  amountAsset: string,
-  amount: BigNumber.Value,
+export interface AddLiquidityParams {
+  poolName: string
+  amountAsset: string
+  amount: BigNumber.Value
   signer: ethers.Signer
 }
 
-export type RemoveAllLiquidityParams = {
-  poolName: string,
+export interface RemoveAllLiquidityParams {
+  poolName: string
   signer: ethers.Signer
 }
 
@@ -57,14 +57,14 @@ export default class FarmingManager {
       .connect(exchangeContractAddress, this.orionUnit.provider);
 
     const assetAAddress = assetToAddress[assetA];
-    if (!assetAAddress) throw new Error(`Asset '${assetA}' not found`);
+    if (assetAAddress === undefined) throw new Error(`Asset '${assetA}' not found`);
     const assetBAddress = assetToAddress[assetB];
-    if (!assetBAddress) throw new Error(`Asset '${assetB}' not found`);
+    if (assetBAddress === undefined) throw new Error(`Asset '${assetB}' not found`);
 
     const assetADecimals = assetToDecimals[assetA];
-    if (!assetADecimals) throw new Error(`Decimals for asset '${assetA}' not found`);
+    if (assetADecimals === undefined) throw new Error(`Decimals for asset '${assetA}' not found`);
     const assetBDecimals = assetToDecimals[assetB];
-    if (!assetBDecimals) throw new Error(`Decimals for asset '${assetB}' not found`);
+    if (assetBDecimals === undefined) throw new Error(`Decimals for asset '${assetB}' not found`);
 
     const nativeCryptocurrency = getNativeCryptocurrency(assetToAddress);
     const balances = await getBalances(
@@ -90,7 +90,7 @@ export default class FarmingManager {
 
     const poolsConfig = await simpleFetch(this.orionUnit.orionBlockchain.getPoolsConfig)();
     const pool = poolsConfig.pools[poolName];
-    if (!pool) throw new Error(`Pool ${poolName} not found`);
+    if (pool == null) throw new Error(`Pool ${poolName} not found`);
 
     const pairContract = IUniswapV2Pair__factory
       .connect(pool.lpTokenAddress, this.orionUnit.provider);
@@ -145,7 +145,7 @@ export default class FarmingManager {
       sources: ['exchange', 'wallet'],
     });
 
-    const unsignedTx = await exchangeContract?.populateTransaction.withdrawToPool(
+    const unsignedTx = await exchangeContract.populateTransaction.withdrawToPool(
       assetBIsNativeCurrency ? assetBAddress : assetAAddress,
       assetBIsNativeCurrency ? assetAAddress : assetBAddress,
       assetBIsNativeCurrency
@@ -183,7 +183,7 @@ export default class FarmingManager {
 
     if (assetAIsNativeCurrency || assetBIsNativeCurrency) {
       const contractBalance = balances[nativeCryptocurrency]?.exchange;
-      if (!contractBalance) throw new Error(`No balance for '${nativeCryptocurrency}'`);
+      if (contractBalance == null) throw new Error(`No balance for '${nativeCryptocurrency}'`);
       const nativeAssetAmount = assetBIsNativeCurrency ? assetBAmount : assetAAmount;
 
       if (nativeAssetAmount.gt(contractBalance)) {
@@ -231,18 +231,18 @@ export default class FarmingManager {
     } = await simpleFetch(this.orionUnit.orionBlockchain.getInfo)();
 
     const assetAAddress = assetToAddress[assetA];
-    if (!assetAAddress) throw new Error(`Asset '${assetA}' not found`);
+    if (assetAAddress === undefined) throw new Error(`Asset '${assetA}' not found`);
     const assetBAddress = assetToAddress[assetB];
-    if (!assetBAddress) throw new Error(`Asset '${assetB}' not found`);
+    if (assetBAddress === undefined) throw new Error(`Asset '${assetB}' not found`);
 
     const assetADecimals = assetToDecimals[assetA];
-    if (!assetADecimals) throw new Error(`Decimals for asset '${assetA}' not found`);
+    if (assetADecimals === undefined) throw new Error(`Decimals for asset '${assetA}' not found`);
     const assetBDecimals = assetToDecimals[assetB];
-    if (!assetBDecimals) throw new Error(`Decimals for asset '${assetB}' not found`);
+    if (assetBDecimals === undefined) throw new Error(`Decimals for asset '${assetB}' not found`);
 
     const poolsConfig = await simpleFetch(this.orionUnit.orionBlockchain.getPoolsConfig)();
     const pool = poolsConfig.pools[poolName];
-    if (!pool) throw new Error(`Pool ${poolName} not found`);
+    if (pool == null) throw new Error(`Pool ${poolName} not found`);
 
     const walletAddress = await signer.getAddress();
 

src/OrionUnit/index.ts

@@ -6,7 +6,7 @@ import type { SupportedChainId, VerboseOrionUnitConfig } from '../types';
 import Exchange from './Exchange';
 import FarmingManager from './FarmingManager';
 import { chains } from '../config';
-import { networkCodes } from '../constants';
+import { type networkCodes } from '../constants';
 
 // type KnownConfig = {
 //   env: string;
@@ -42,7 +42,7 @@ export default class OrionUnit {
   constructor(config: VerboseOrionUnitConfig) {
     this.config = config;
     const chainInfo = chains[config.chainId];
-    if (!chainInfo) throw new Error('Chain info is required');
+    if (chainInfo === undefined) throw new Error('Chain info is required');
 
     // if ('env' in config)
     // this.env = config.env;