From fbf30334559d8803a6402985f5a380414229dbf3 Mon Sep 17 00:00:00 2001
From: Arunavo Ray <developer@arunavoray.dev>
Date: Tue, 17 Jun 2025 15:06:54 +0530
Subject: [PATCH] refactor: remove ConnectionsForm and useMirror hook; update
 issue mirroring logic for starred repos

---
 src/components/config/ConnectionsForm.tsx     | 47 -----------
 .../config/GitHubMirrorSettings.tsx           | 10 +--
 src/hooks/useMirror.ts                        | 83 -------------------
 src/lib/gitea.ts                              | 12 ++-
 4 files changed, 15 insertions(+), 137 deletions(-)
 delete mode 100644 src/components/config/ConnectionsForm.tsx
 delete mode 100644 src/hooks/useMirror.ts

diff --git a/src/components/config/ConnectionsForm.tsx b/src/components/config/ConnectionsForm.tsx
deleted file mode 100644
index 7ce0629..0000000
--- a/src/components/config/ConnectionsForm.tsx
+++ /dev/null
@@ -1,47 +0,0 @@
-import React from 'react';
-import { GitHubConfigForm } from './GitHubConfigForm';
-import { GiteaConfigForm } from './GiteaConfigForm';
-import { Separator } from '../ui/separator';
-import type { GitHubConfig, GiteaConfig } from '@/types/config';
-
-interface ConnectionsFormProps {
-  githubConfig: GitHubConfig;
-  giteaConfig: GiteaConfig;
-  setGithubConfig: (update: GitHubConfig | ((prev: GitHubConfig) => GitHubConfig)) => void;
-  setGiteaConfig: (update: GiteaConfig | ((prev: GiteaConfig) => GiteaConfig)) => void;
-  onAutoSaveGitHub?: (config: GitHubConfig) => Promise<void>;
-  onAutoSaveGitea?: (config: GiteaConfig) => Promise<void>;
-  isAutoSavingGitHub?: boolean;
-  isAutoSavingGitea?: boolean;
-}
-
-export function ConnectionsForm({
-  githubConfig,
-  giteaConfig,
-  setGithubConfig,
-  setGiteaConfig,
-  onAutoSaveGitHub,
-  onAutoSaveGitea,
-  isAutoSavingGitHub,
-  isAutoSavingGitea,
-}: ConnectionsFormProps) {
-  return (
-    <div className="space-y-6">
-      <GitHubConfigForm
-        config={githubConfig}
-        setConfig={setGithubConfig}
-        onAutoSave={onAutoSaveGitHub}
-        isAutoSaving={isAutoSavingGitHub}
-      />
-      
-      <Separator />
-      
-      <GiteaConfigForm
-        config={giteaConfig}
-        setConfig={setGiteaConfig}
-        onAutoSave={onAutoSaveGitea}
-        isAutoSaving={isAutoSavingGitea}
-      />
-    </div>
-  );
-}
diff --git a/src/components/config/GitHubMirrorSettings.tsx b/src/components/config/GitHubMirrorSettings.tsx
index eb9d701..7799de8 100644
--- a/src/components/config/GitHubMirrorSettings.tsx
+++ b/src/components/config/GitHubMirrorSettings.tsx
@@ -225,7 +225,7 @@ export function GitHubMirrorSettings({
                               <div className="flex items-center gap-2 text-xs pl-2">
                                 <GitBranch className="h-3 w-3 text-muted-foreground" />
                                 <span>Source code</span>
-                                <Badge variant="secondary" className="ml-auto text-[10px] px-1 h-4">Always</Badge>
+                                <Badge variant="secondary" className="ml-auto text-[10px] px-2 h-4">Always</Badge>
                               </div>
                               
                               <div className={cn(
@@ -234,7 +234,7 @@ export function GitHubMirrorSettings({
                               )}>
                                 <Tag className="h-3 w-3 text-muted-foreground" />
                                 <span>Releases & Tags</span>
-                                {starredRepoContent.releases && <Badge variant="outline" className="ml-auto text-[10px] px-1 h-4">Included</Badge>}
+                                {starredRepoContent.releases && <Badge variant="outline" className="ml-auto text-[10px] px-2 h-4">Included</Badge>}
                               </div>
                               
                               <div className={cn(
@@ -243,7 +243,7 @@ export function GitHubMirrorSettings({
                               )}>
                                 <MessageSquare className="h-3 w-3 text-muted-foreground" />
                                 <span>Issues</span>
-                                {starredRepoContent.issues && <Badge variant="outline" className="ml-auto text-[10px] px-1 h-4">Included</Badge>}
+                                {starredRepoContent.issues && <Badge variant="outline" className="ml-auto text-[10px] px-2 h-4">Included</Badge>}
                               </div>
                               
                               <div className={cn(
@@ -252,7 +252,7 @@ export function GitHubMirrorSettings({
                               )}>
                                 <GitPullRequest className="h-3 w-3 text-muted-foreground" />
                                 <span>Pull Requests</span>
-                                {starredRepoContent.pullRequests && <Badge variant="outline" className="ml-auto text-[10px] px-1 h-4">Included</Badge>}
+                                {starredRepoContent.pullRequests && <Badge variant="outline" className="ml-auto text-[10px] px-2 h-4">Included</Badge>}
                               </div>
                               
                               <div className={cn(
@@ -261,7 +261,7 @@ export function GitHubMirrorSettings({
                               )}>
                                 <BookOpen className="h-3 w-3 text-muted-foreground" />
                                 <span>Wiki</span>
-                                {starredRepoContent.wiki && <Badge variant="outline" className="ml-auto text-[10px] px-1 h-4">Included</Badge>}
+                                {starredRepoContent.wiki && <Badge variant="outline" className="ml-auto text-[10px] px-2 h-4">Included</Badge>}
                               </div>
                             </div>
                             
diff --git a/src/hooks/useMirror.ts b/src/hooks/useMirror.ts
deleted file mode 100644
index b0a8baa..0000000
--- a/src/hooks/useMirror.ts
+++ /dev/null
@@ -1,83 +0,0 @@
-import { useState } from 'react';
-import { mirrorApi } from '@/lib/api';
-import type { MirrorJob } from '@/lib/db/schema';
-
-export function useMirror() {
-  const [isLoading, setIsLoading] = useState(false);
-  const [error, setError] = useState<string | null>(null);
-  const [currentJob, setCurrentJob] = useState<MirrorJob | null>(null);
-  const [jobs, setJobs] = useState<MirrorJob[]>([]);
-
-  const startMirror = async (configId: string, repositoryIds?: string[]) => {
-    setIsLoading(true);
-    setError(null);
-    try {
-      const job = await mirrorApi.startMirror(configId, repositoryIds);
-      setCurrentJob(job);
-      return job;
-    } catch (err) {
-      setError(err instanceof Error ? err.message : 'Failed to start mirroring');
-      throw err;
-    } finally {
-      setIsLoading(false);
-    }
-  };
-
-  const getMirrorJobs = async (configId: string) => {
-    setIsLoading(true);
-    setError(null);
-    try {
-      const fetchedJobs = await mirrorApi.getMirrorJobs(configId);
-      setJobs(fetchedJobs);
-      return fetchedJobs;
-    } catch (err) {
-      setError(err instanceof Error ? err.message : 'Failed to fetch mirror jobs');
-      throw err;
-    } finally {
-      setIsLoading(false);
-    }
-  };
-
-  const getMirrorJob = async (jobId: string) => {
-    setIsLoading(true);
-    setError(null);
-    try {
-      const job = await mirrorApi.getMirrorJob(jobId);
-      setCurrentJob(job);
-      return job;
-    } catch (err) {
-      setError(err instanceof Error ? err.message : 'Failed to fetch mirror job');
-      throw err;
-    } finally {
-      setIsLoading(false);
-    }
-  };
-
-  const cancelMirrorJob = async (jobId: string) => {
-    setIsLoading(true);
-    setError(null);
-    try {
-      const result = await mirrorApi.cancelMirrorJob(jobId);
-      if (result.success && currentJob?.id === jobId) {
-        setCurrentJob({ ...currentJob, status: 'failed' });
-      }
-      return result;
-    } catch (err) {
-      setError(err instanceof Error ? err.message : 'Failed to cancel mirror job');
-      throw err;
-    } finally {
-      setIsLoading(false);
-    }
-  };
-
-  return {
-    isLoading,
-    error,
-    currentJob,
-    jobs,
-    startMirror,
-    getMirrorJobs,
-    getMirrorJob,
-    cancelMirrorJob,
-  };
-}
diff --git a/src/lib/gitea.ts b/src/lib/gitea.ts
index d39b6e9..56962d1 100644
--- a/src/lib/gitea.ts
+++ b/src/lib/gitea.ts
@@ -263,7 +263,11 @@ export const mirrorGithubRepoToGitea = async ({
     });
 
     // clone issues
-    if (config.githubConfig.mirrorIssues) {
+    // Skip issues for starred repos if skipStarredIssues is enabled
+    const shouldMirrorIssues = config.githubConfig.mirrorIssues && 
+      !(repository.isStarred && config.githubConfig.skipStarredIssues);
+    
+    if (shouldMirrorIssues) {
       await mirrorGitRepoIssuesToGitea({
         config,
         octokit,
@@ -608,7 +612,11 @@ export async function mirrorGitHubRepoToGiteaOrg({
     });
 
     // Clone issues
-    if (config.githubConfig?.mirrorIssues) {
+    // Skip issues for starred repos if skipStarredIssues is enabled
+    const shouldMirrorIssues = config.githubConfig?.mirrorIssues && 
+      !(repository.isStarred && config.githubConfig?.skipStarredIssues);
+    
+    if (shouldMirrorIssues) {
       await mirrorGitRepoIssuesToGitea({
         config,
         octokit,