create a request validator engine

This commit is contained in:
mini-bomba
2025-04-25 19:38:54 +02:00
parent 920d288f0b
commit f7e5394a18
7 changed files with 269 additions and 45 deletions

View File

@@ -108,34 +108,6 @@ export async function canSubmit(userID: HashedUserID, category: Category): Promi
}
}
export function validSubmittedData(userAgent: string, userAgentR: string): boolean {
if (!config.validityCheck.userAgent) {
return true;
}
for (const key of Object.keys(config.validityCheck)) {
const check = (config.validityCheck as Record<string, string | null>)[key];
if (check === null) {
continue;
} else {
switch (key) {
case "userAgent":
if (!userAgent.match(check)) {
return false;
}
break;
case "userAgentR":
if (!userAgentR.match(new RegExp(check))) {
return false;
}
break;
}
}
}
return true;
}
export async function canSubmitGlobal(userID: HashedUserID): Promise<CanSubmitGlobalResult> {
const oldSubmitterOrAllowedPromise = oldSubmitterOrAllowed(userID);
@@ -158,4 +130,4 @@ export async function canSubmitDeArrow(userID: HashedUserID): Promise<CanSubmitG
newUser: (await oldSubmitterOrAllowedPromise).newUser,
reason: "We are currently experiencing a mass spam attack, we are restricting submissions for now"
};
}
}

View File

@@ -0,0 +1,215 @@
import { config } from "../config";
import { ThumbnailSubmission, TitleSubmission } from "../types/branding.model";
import { ValidatorPattern, RequestValidatorRule } from "../types/config.model";
import { IncomingSegment } from "../types/segments.model";
export interface RequestValidatorInput {
userAgent?: string;
userAgentHeader?: string;
videoDuration?: string | number;
userID?: string;
service?: string;
segments?: IncomingSegment[];
dearrow?: {
title?: TitleSubmission;
thumbnail?: ThumbnailSubmission;
downvote: boolean;
};
}
export type CompiledValidityCheck = (input: RequestValidatorInput) => boolean;
type CompiledSegmentCheck = (input: IncomingSegment) => boolean;
type InputExtractor = (input: RequestValidatorInput) => string | number | undefined | null;
type SegmentExtractor = (input: IncomingSegment) => string | undefined | null;
type BooleanRules = "titleOriginal" | "thumbnailOriginal" | "dearrowDownvote";
type RuleEntry =
| [Exclude<keyof RequestValidatorRule, BooleanRules>, ValidatorPattern]
| [BooleanRules, boolean];
let compiledRules: CompiledValidityCheck;
function compilePattern(
pattern: ValidatorPattern,
extractor: InputExtractor,
): CompiledValidityCheck {
const regex =
typeof pattern === "string"
? new RegExp(pattern, "i")
: new RegExp(...pattern);
return (input: RequestValidatorInput) => {
const field = extractor(input);
if (field == undefined) return false;
return regex.test(String(field));
};
}
function compileSegmentPattern(
pattern: ValidatorPattern,
extractor: SegmentExtractor,
): CompiledSegmentCheck {
const regex =
typeof pattern === "string"
? new RegExp(pattern, "i")
: new RegExp(...pattern);
return (input: IncomingSegment) => {
const field = extractor(input);
if (field == undefined) return false;
return regex.test(field);
};
}
export function compileRules(
ruleDefinitions: RequestValidatorRule[],
): CompiledValidityCheck {
if (ruleDefinitions.length === 0) return () => false;
const rules: CompiledValidityCheck[] = [];
for (const ruleDefinition of ruleDefinitions) {
const ruleComponents: CompiledValidityCheck[] = [];
const segmentRuleComponents: CompiledSegmentCheck[] = [];
for (const [ruleKey, rulePattern] of Object.entries(
ruleDefinition,
) as RuleEntry[]) {
switch (ruleKey) {
case "userAgent":
ruleComponents.push(
compilePattern(rulePattern, (input) => input.userAgent),
);
break;
case "userAgentHeader":
ruleComponents.push(
compilePattern(
rulePattern,
(input) => input.userAgentHeader,
),
);
break;
case "videoDuration":
ruleComponents.push(
compilePattern(
rulePattern,
(input) => input.videoDuration,
),
);
break;
case "userID":
ruleComponents.push(
compilePattern(rulePattern, (input) => input.userID),
);
break;
case "service":
ruleComponents.push(
compilePattern(rulePattern, (input) => input.service),
);
break;
case "startTime":
segmentRuleComponents.push(
compileSegmentPattern(
rulePattern,
(input) => input.segment[0],
),
);
break;
case "endTime":
segmentRuleComponents.push(
compileSegmentPattern(
rulePattern,
(input) => input.segment[1],
),
);
break;
case "category":
segmentRuleComponents.push(
compileSegmentPattern(
rulePattern,
(input) => input.category,
),
);
break;
case "actionType":
segmentRuleComponents.push(
compileSegmentPattern(
rulePattern,
(input) => input.actionType,
),
);
break;
case "description":
segmentRuleComponents.push(
compileSegmentPattern(
rulePattern,
(input) => input.description,
),
);
break;
case "title":
ruleComponents.push(
compilePattern(
rulePattern,
(input) => input.dearrow?.title?.title,
),
);
break;
case "titleOriginal":
ruleComponents.push(
(input) => input.dearrow?.title?.original === rulePattern,
);
break;
case "thumbnailTimestamp":
ruleComponents.push(
compilePattern(
rulePattern,
(input) => input.dearrow?.thumbnail?.timestamp,
),
);
break;
case "thumbnailOriginal":
ruleComponents.push(
(input) =>
input.dearrow?.thumbnail?.original === rulePattern,
);
break;
case "dearrowDownvote":
ruleComponents.push(
(input) =>
input.dearrow?.downvote === rulePattern,
);
break;
}
}
if (segmentRuleComponents.length > 0) {
ruleComponents.push((input) => {
if (input.segments === undefined) return false;
for (const segment of input.segments) {
let result = true;
for (const rule of segmentRuleComponents) {
if (!rule(segment)) {
result = false;
break;
}
}
if (result) return true;
}
return false;
});
}
rules.push((input) => {
for (const rule of ruleComponents) {
if (!rule(input)) return false;
}
return true;
});
}
return (input) => {
for (const rule of rules) {
if (rule(input)) return true;
}
return false;
};
}
export function isRequestInvalid(input: RequestValidatorInput) {
compiledRules ??= compileRules(config.requestValidatorRules);
return compiledRules(input);
}