From ed5a397a30e94aa52cecec562b99d941216cba61 Mon Sep 17 00:00:00 2001
From: Ajay <dev@ajay.app>
Date: Tue, 15 Apr 2025 02:01:41 -0400
Subject: [PATCH] Improve permission check

---
 src/utils/permissions.ts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/utils/permissions.ts b/src/utils/permissions.ts
index 9e55026..f4427fb 100644
--- a/src/utils/permissions.ts
+++ b/src/utils/permissions.ts
@@ -29,7 +29,7 @@ async function oldSubmitterOrAllowed(userID: HashedUserID): Promise<boolean> {
         return true;
     }
 
-    const result = await db.prepare("get", `SELECT count(*) as "submissionCount" FROM "sponsorTimes" WHERE "userID" = ? AND "timeSubmitted" < ?`
+    const result = await db.prepare("get", `SELECT count(*) as "submissionCount" FROM "sponsorTimes" WHERE "userID" = ? AND "shadowHidden" = 0 AND "votes" >= 0 AND "timeSubmitted" < ?`
         , [userID, parseInt(submitterThreshold) || Infinity], { useReplica: true });
 
     const isOldSubmitter = result.submissionCount >= 1;
@@ -53,7 +53,7 @@ async function oldDeArrowSubmitterOrAllowed(userID: HashedUserID): Promise<boole
         return true;
     }
 
-    const result = await db.prepare("get", `SELECT count(*) as "submissionCount" FROM "titles" WHERE "userID" = ? AND "timeSubmitted" < ?`
+    const result = await db.prepare("get", `SELECT count(*) as "submissionCount" FROM "titles" JOIN "titleVotes" ON "titles"."UUID" = "titleVotes"."UUID" WHERE "userID" = ? AND "shadowHidden" = 0 AND "votes" >= 0 AND "timeSubmitted" < ?`
         , [userID, parseInt(submitterThreshold) || Infinity], { useReplica: true });
 
     const isOldSubmitter = result.submissionCount >= 1;