From 544af7ce155947c73338201f75f6784eb1e31a39 Mon Sep 17 00:00:00 2001
From: Michael C <michael@mchang.name>
Date: Sat, 18 Dec 2021 21:32:13 -0500
Subject: [PATCH 1/2] remove empty rows from userNames

---
 src/routes/setUsername.ts |  3 ++-
 test/cases/setUsername.ts | 11 +++++++++++
 2 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/src/routes/setUsername.ts b/src/routes/setUsername.ts
index e31328c..1f24780 100644
--- a/src/routes/setUsername.ts
+++ b/src/routes/setUsername.ts
@@ -70,7 +70,8 @@ export async function setUsername(req: Request, res: Response): Promise<Response
         if (row?.userName !== undefined) {
             //already exists, update this row
             oldUserName = row.userName;
-            await db.prepare("run", `UPDATE "userNames" SET "userName" = ?, "locked" = ? WHERE "userID" = ?`, [userName, locked, userID]);
+            if (userName == userID && !locked) await db.prepare("run", `DELETE FROM "userNames" WHERE "userID" = ?`, [userID]);
+            else await db.prepare("run", `UPDATE "userNames" SET "userName" = ?, "locked" = ? WHERE "userID" = ?`, [userName, locked, userID]);
         } else {
             //add to the db
             await db.prepare("run", `INSERT INTO "userNames"("userID", "userName", "locked") VALUES(?, ?, ?)`, [userID, userName, locked]);
diff --git a/test/cases/setUsername.ts b/test/cases/setUsername.ts
index 89af032..39a518b 100644
--- a/test/cases/setUsername.ts
+++ b/test/cases/setUsername.ts
@@ -20,6 +20,7 @@ const user06PrivateUserID = "setUsername_06";
 const username06 = "Username 06";
 const user07PrivateUserID = "setUsername_07";
 const username07 = "Username 07";
+const user08PrivateUserID = "setUsername_08";
 
 async function addUsername(userID: string, userName: string, locked = 0) {
     await db.prepare("run", 'INSERT INTO "userNames" ("userID", "userName", "locked") VALUES(?, ?, ?)', [userID, userName, locked]);
@@ -231,4 +232,14 @@ describe("setUsername", () => {
             })
             .catch((err) => done(err));
     });
+
+    it("Should delete row if new username is same as publicID", (done) => {
+        const publicID = getHash(user08PrivateUserID);
+        postSetUserName(getHash(user08PrivateUserID), publicID)
+            .then(async () => {
+                const usernameInfo = await getUsernameInfo(getHash(user08PrivateUserID));
+                assert.strictEqual(usernameInfo, null);
+                done();
+            });
+    });
 });

From 0f4b0c2f54dd9d6dc935046c34128215cfa5f550 Mon Sep 17 00:00:00 2001
From: Ajay Ramachandran <dev@ajay.app>
Date: Sun, 19 Dec 2021 19:13:49 -0500
Subject: [PATCH 2/2] formatting

---
 src/routes/setUsername.ts | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/routes/setUsername.ts b/src/routes/setUsername.ts
index 1f24780..81e5a54 100644
--- a/src/routes/setUsername.ts
+++ b/src/routes/setUsername.ts
@@ -70,8 +70,11 @@ export async function setUsername(req: Request, res: Response): Promise<Response
         if (row?.userName !== undefined) {
             //already exists, update this row
             oldUserName = row.userName;
-            if (userName == userID && !locked) await db.prepare("run", `DELETE FROM "userNames" WHERE "userID" = ?`, [userID]);
-            else await db.prepare("run", `UPDATE "userNames" SET "userName" = ?, "locked" = ? WHERE "userID" = ?`, [userName, locked, userID]);
+            if (userName == userID && !locked) {
+                await db.prepare("run", `DELETE FROM "userNames" WHERE "userID" = ?`, [userID]);
+            } else {
+                await db.prepare("run", `UPDATE "userNames" SET "userName" = ?, "locked" = ? WHERE "userID" = ?`, [userName, locked, userID]);
+            }
         } else {
             //add to the db
             await db.prepare("run", `INSERT INTO "userNames"("userID", "userName", "locked") VALUES(?, ?, ?)`, [userID, userName, locked]);