From c3a5b22dadd699b3f33aefe230ffc0355cb4d189 Mon Sep 17 00:00:00 2001
From: Ajay Ramachandran <dev@ajay.app>
Date: Sat, 28 Aug 2021 00:18:31 -0400
Subject: [PATCH] Move unHideSubmissions to helper function

---
 src/routes/shadowBanUser.ts | 36 ++++++++++++++++--------------------
 1 file changed, 16 insertions(+), 20 deletions(-)

diff --git a/src/routes/shadowBanUser.ts b/src/routes/shadowBanUser.ts
index b1196b0..bd04760 100644
--- a/src/routes/shadowBanUser.ts
+++ b/src/routes/shadowBanUser.ts
@@ -48,16 +48,7 @@ export async function shadowBanUser(req: Request, res: Response): Promise<Respon
 
             //find all previous submissions and hide them
             if (unHideOldSubmissions) {
-                await db.prepare("run", `UPDATE "sponsorTimes" SET "shadowHidden" = 1 WHERE "userID" = ? AND "category" in (${categories.map((c) => `'${c}'`).join(",")})
-                    AND NOT EXISTS ( SELECT "videoID", "category" FROM "lockCategories" WHERE
-                    "sponsorTimes"."videoID" = "lockCategories"."videoID" AND "sponsorTimes"."category" = "lockCategories"."category")`, [userID]);
-
-                // clear cache for all old videos
-                (await db.prepare("all", `SELECT "videoID", "hashedVideoID", "service", "votes", "views" FROM "sponsorTimes" WHERE "userID" = ?`, [userID]))
-                    .forEach((videoInfo: {category: Category, videoID: VideoID, hashedVideoID: VideoIDHash, service: Service, userID: UserID}) => {
-                        QueryCacher.clearVideoCache(videoInfo);
-                    }
-                    );
+                await unHideSubmissions(categories, userID);
             }
         } else if (!enabled && row.userCount > 0) {
             //remove them from the shadow ban list
@@ -88,18 +79,10 @@ export async function shadowBanUser(req: Request, res: Response): Promise<Respon
         } else if (enabled && row.userCount > 0) {
             // apply unHideOldSubmissions if applicable
             if (unHideOldSubmissions) {
-                await db.prepare("run", `UPDATE "sponsorTimes" SET "shadowHidden" = 1 WHERE "userID" = ? AND "category" in (${categories.map((c) => `'${c}'`).join(",")})
-                    AND NOT EXISTS ( SELECT "videoID", "category" FROM "lockCategories" WHERE
-                    "sponsorTimes"."videoID" = "lockCategories"."videoID" AND "sponsorTimes"."category" = "lockCategories"."category")`, [userID]);
-
-                // clear cache for all old videos
-                (await db.prepare("all", `SELECT "videoID", "hashedVideoID", "service", "votes", "views" FROM "sponsorTimes" WHERE "userID" = ?`, [userID]))
-                    .forEach((videoInfo: {category: Category, videoID: VideoID, hashedVideoID: VideoIDHash, service: Service, userID: UserID}) => {
-                        QueryCacher.clearVideoCache(videoInfo);
-                    }
-                    );
+                await unHideSubmissions(categories, userID);
                 return res.sendStatus(200);
             }
+
             // otherwise ban already exists, send 409
             return res.sendStatus(409);
         }
@@ -133,3 +116,16 @@ export async function shadowBanUser(req: Request, res: Response): Promise<Respon
     }
     return res.sendStatus(200);
 }
+
+async function unHideSubmissions(categories: string[], userID: UserID) {
+    await db.prepare("run", `UPDATE "sponsorTimes" SET "shadowHidden" = 1 WHERE "userID" = ? AND "category" in (${categories.map((c) => `'${c}'`).join(",")})
+                    AND NOT EXISTS ( SELECT "videoID", "category" FROM "lockCategories" WHERE
+                    "sponsorTimes"."videoID" = "lockCategories"."videoID" AND "sponsorTimes"."category" = "lockCategories"."category")`, [userID]);
+
+    // clear cache for all old videos
+    (await db.prepare("all", `SELECT "videoID", "hashedVideoID", "service", "votes", "views" FROM "sponsorTimes" WHERE "userID" = ?`, [userID]))
+        .forEach((videoInfo: { category: Category; videoID: VideoID; hashedVideoID: VideoIDHash; service: Service; userID: UserID; }) => {
+            QueryCacher.clearVideoCache(videoInfo);
+        }
+    ); //eslint-disable-line
+}
\ No newline at end of file