Merge pull request #163 from thignus/reject-80percent-total-submissions

reject submissions if total length is more than 80 precent of the video

src/routes/postSkipSegments.js

@@ -50,7 +50,7 @@ function sendWebhooks(userID, videoID, UUID, segmentInfo) {
     if (config.youtubeAPIKey !== null) {
         let userSubmissionCountRow = db.prepare('get', "SELECT count(*) as submissionCount FROM sponsorTimes WHERE userID = ?", [userID]);
 
-        YouTubeAPI.listVideos(videoID, "snippet", (err, data) => {
+        YouTubeAPI.listVideos(videoID, (err, data) => {
             if (err || data.items.length === 0) {
                 err && logger.error(err);
                 return;
@@ -154,7 +154,7 @@ async function autoModerateSubmission(submission) {
     // Get the video information from the youtube API
     if (config.youtubeAPIKey !== null) {
         let {err, data} = await new Promise((resolve, reject) => {
-            YouTubeAPI.listVideos(submission.videoID, "contentDetails,snippet", (err, data) => resolve({err, data}));
+            YouTubeAPI.listVideos(submission.videoID, (err, data) => resolve({err, data}));
         });
 
         if (err) {
@@ -406,6 +406,45 @@ module.exports = async function postSkipSegments(req, res) {
             startingVotes = 10000;
         }
 
+        if (config.youtubeAPIKey !== null) {
+            let {err, data} = await new Promise((resolve, reject) => {
+                YouTubeAPI.listVideos(videoID, (err, data) => resolve({err, data}));
+            });
+
+            //get all segments for this video and user
+            let allSubmittedByUser = db.prepare('all', "SELECT startTime, endTime FROM sponsorTimes WHERE userID = ? and videoID = ? and votes > -1", [userID, videoID]);
+            let allSegmentTimes = [];
+            if (allSubmittedByUser !== undefined) {
+                //add segments the user has previously submitted
+                for (const segmentInfo of allSubmittedByUser) {
+                    allSegmentTimes.push([parseFloat(segmentInfo.startTime), parseFloat(segmentInfo.endTime)])
+                }
+            }
+
+            //add segments they are trying to add in this submission
+            for (let i = 0; i < segments.length; i++) {
+                let startTime = parseFloat(segments[i].segment[0]);
+                let endTime = parseFloat(segments[i].segment[1]);
+                allSegmentTimes.push([startTime, endTime]);
+            }
+
+            //merge all the times into non-overlapping arrays
+            const allSegmentsSorted = mergeTimeSegments(allSegmentTimes.sort(function(a, b) { return a[0]-b[0] || a[1]-b[1] }));
+
+            let videoDuration = data.items[0].contentDetails.duration;
+            videoDuration = isoDurations.toSeconds(isoDurations.parse(videoDuration));
+            if (videoDuration != 0) {
+                let allSegmentDuration = 0;
+                //sum all segment times together
+                allSegmentsSorted.forEach(segmentInfo => allSegmentDuration += segmentInfo[1] - segmentInfo[0]);
+                if (allSegmentDuration > (videoDuration/100)*80) {
+                    // Reject submission if all segments combine are over 80% of the video
+                    res.status(400).send("Total length of your submitted segments are over 80% of the video.");
+                    return;
+                }
+            }
+        }
+
         for (const segmentInfo of segments) {
             //this can just be a hash of the data
             //it's better than generating an actual UUID like what was used before
@@ -447,3 +486,30 @@ module.exports = async function postSkipSegments(req, res) {
         sendWebhooks(userID, videoID, UUIDs[i], segments[i]);
     }
 }
+
+// Takes an array of arrays: 
+// ex) 
+// [
+//     [3, 40], 
+//     [50, 70], 
+//     [60, 80], 
+//     [100, 150]
+// ] 
+// => transforms to combining overlapping segments
+// [
+//     [3, 40],
+//     [50, 80], 
+//     [100, 150]
+// ]
+function mergeTimeSegments(ranges) {
+    var result = [], last;
+
+    ranges.forEach(function (r) {
+        if (!last || r[0] > last[1])
+            result.push(last = r);
+        else if (r[1] > last[1])
+            last[1] = r[1];
+    });
+
+    return result;
+}

src/routes/voteOnSponsorTime.js

@@ -49,7 +49,7 @@ function sendWebhooks(voteData) {
         }
 
         if (config.youtubeAPIKey !== null) {
-            YouTubeAPI.listVideos(submissionInfoRow.videoID, "snippet", (err, data) => {
+            YouTubeAPI.listVideos(submissionInfoRow.videoID, (err, data) => {
                 if (err || data.items.length === 0) {
                     err && logger.error(err);
                     return;

src/utils/youtubeAPI.js

@@ -18,13 +18,14 @@ if (config.mode === "test") {
     exportObject = YouTubeAPI;
 
     // YouTubeAPI.videos.list wrapper with cacheing
-    exportObject.listVideos = (videoID, part, callback) => {
+    exportObject.listVideos = (videoID, callback) => {
+        let part = 'contentDetails,snippet';
         if (videoID.length !== 11 || videoID.includes(".")) {
             callback("Invalid video ID");
             return;
         }
 
-        let redisKey = "youtube.video." + videoID + "." + part;
+        let redisKey = "youtube.video." + videoID;
         redis.get(redisKey, (getErr, result) => {
             if (getErr || !result) {
                 logger.debug("redis: no cache for video information: " + videoID);