From 9b0ba9031ea819cf83ee0f39860dfccc83f0b0b0 Mon Sep 17 00:00:00 2001 From: Nanobyte Date: Thu, 15 Apr 2021 01:22:25 +0200 Subject: [PATCH] Optimize code --- src/routes/getUserInfo.ts | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/routes/getUserInfo.ts b/src/routes/getUserInfo.ts index eb96c48..9960ece 100644 --- a/src/routes/getUserInfo.ts +++ b/src/routes/getUserInfo.ts @@ -5,7 +5,7 @@ import {Logger} from '../utils/logger' async function dbGetSubmittedSegmentSummary(userID: string): Promise<{ minutesSaved: number, segmentCount: number }> { try { - let row = await db.prepare("get", `SELECT SUM((("endTime" - "startTime") / 60) * "views") as "minutesSaved", count(*) as "segmentCount" FROM "sponsorTimes" WHERE "userID" = ? AND "votes" > -2 AND "shadowHidden" != 1`, [userID]); + let row = await db.prepare("get", `SELECT SUM((("endTime" - "startTime") / 60) * "views") as "minutesSaved", count(1) as "segmentCount" FROM "sponsorTimes" WHERE "userID" = ? AND "votes" > -2 AND "shadowHidden" != 1`, [userID]); if (row.minutesSaved != null) { return { minutesSaved: row.minutesSaved, @@ -39,12 +39,7 @@ async function dbGetUsername(userID: string) { async function dbGetViewsForUser(userID: string) { try { let row = await db.prepare('get', `SELECT SUM("views") as "viewCount" FROM "sponsorTimes" WHERE "userID" = ? AND "votes" > -2 AND "shadowHidden" != 1`, [userID]); - //increase the view count by one - if (row.viewCount != null) { - return row.viewCount; - } else { - return 0; - } + return row?.viewCount ?? 0; } catch (err) { return false; }