From 96db571a5ec41f550519b385dd6b86d03abcfe42 Mon Sep 17 00:00:00 2001 From: Ajay Date: Thu, 27 Oct 2022 20:00:04 -0400 Subject: [PATCH] Fix request rate limit option not working --- src/app.ts | 2 +- src/middleware/requestRateLimit.ts | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/app.ts b/src/app.ts index f68507e..87ea50a 100644 --- a/src/app.ts +++ b/src/app.ts @@ -80,7 +80,7 @@ function setupRoutes(router: Router) { // Rate limit endpoint lists const voteEndpoints: RequestHandler[] = [voteOnSponsorTime]; const viewEndpoints: RequestHandler[] = [viewedVideoSponsorTime]; - if (config.rateLimit) { + if (config.rateLimit && config.redisRateLimit) { if (config.rateLimit.vote) voteEndpoints.unshift(rateLimitMiddleware(config.rateLimit.vote, voteGetUserID)); if (config.rateLimit.view) viewEndpoints.unshift(rateLimitMiddleware(config.rateLimit.view)); } diff --git a/src/middleware/requestRateLimit.ts b/src/middleware/requestRateLimit.ts index b9b8c79..27640c7 100644 --- a/src/middleware/requestRateLimit.ts +++ b/src/middleware/requestRateLimit.ts @@ -32,8 +32,7 @@ export function rateLimitMiddleware(limitConfig: RateLimitConfig, getUserID?: (r } }, store: config.redis?.enabled ? new RedisStore({ - sendCommand: (...args: string[]) => config.redisRateLimit ? redis.sendCommand(args).catch((err) => Logger.error(err)) as Promise - : Promise.resolve(null) as Promise, + sendCommand: (...args: string[]) => redis.sendCommand(args).catch((err) => Logger.error(err)) as Promise, }) : null, }); } catch (e) {