From 8ee51a1cb077533bb2f2f3b304c459b97f1ce620 Mon Sep 17 00:00:00 2001
From: Michael C <michael@mchang.name>
Date: Wed, 14 Jul 2021 14:11:34 -0400
Subject: [PATCH] testing CI

---
 src/routes/getLockCategoriesByHash.ts | 3 +--
 test/cases/getSkipSegmentsByHash.ts   | 4 ++--
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/routes/getLockCategoriesByHash.ts b/src/routes/getLockCategoriesByHash.ts
index 3376539..fbc8372 100644
--- a/src/routes/getLockCategoriesByHash.ts
+++ b/src/routes/getLockCategoriesByHash.ts
@@ -25,7 +25,7 @@ const mergeLocks = (source: DBLock[]) => {
         const destMatch = dest.find(s => s.videoID === obj.videoID);
         if (destMatch) {
             // override longer reason
-            if (obj.reason.length > destMatch.reason.length) destMatch.reason = obj.reason;
+            if (obj.reason?.length > destMatch.reason?.length) destMatch.reason = obj.reason;
             // push to categories
             destMatch.categories.push(obj.category);
         } else {
@@ -40,7 +40,6 @@ const mergeLocks = (source: DBLock[]) => {
     return dest;
 };
 
-
 export async function getLockCategoriesByHash(req: Request, res: Response): Promise<Response> {
     let hashPrefix = req.params.prefix as VideoIDHash;
     if (!hashPrefixTester(req.params.prefix)) {
diff --git a/test/cases/getSkipSegmentsByHash.ts b/test/cases/getSkipSegmentsByHash.ts
index de74414..f78e8bb 100644
--- a/test/cases/getSkipSegmentsByHash.ts
+++ b/test/cases/getSkipSegmentsByHash.ts
@@ -106,10 +106,10 @@ describe("getSkipSegmentsByHash", () => {
             .catch(err => done(err));
     });
 
-    it("Should return 404 for no hash", (done: Done) => {
+    it("Should return 400 for no hash", (done: Done) => {
         fetch(`${getbaseURL()}/api/skipSegments/?categories=["shilling"]`)
             .then(res => {
-                assert.strictEqual(res.status, 404);
+                assert.strictEqual(res.status, 400);
                 done();
             })
             .catch(err => done(err));