Mirror/SponsorBlockServer
1
0
Fork 0
mirror of https://github.com/ajayyy/SponsorBlockServer.git synced 2025-12-16 16:37:12 +03:00
Code Issues Packages Projects Releases Wiki Activity

Add logging for permission rejections

Browse Source
This commit is contained in:
Ajay
2022-08-12 15:26:20 -04:00
parent f4c104215b
commit 6804e7d7a8
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/routes/postSkipSegments.ts
View File

@@ -202,7 +202,7 @@ async function checkUserActiveWarning(userID: string): Promise<CheckResult> {
} }
async function checkInvalidFields(videoID: VideoID, userID: UserID, hashedUserID: HashedUserID async function checkInvalidFields(videoID: VideoID, userID: UserID, hashedUserID: HashedUserID
, segments: IncomingSegment[]): Promise<CheckResult> { , segments: IncomingSegment[], videoDurationParam: number, userAgent: string): Promise<CheckResult> {
const invalidFields = []; const invalidFields = [];
const errors = []; const errors = [];
if (typeof videoID !== "string" || videoID?.length == 0) { if (typeof videoID !== "string" || videoID?.length == 0) {
@@ -232,6 +232,7 @@ async function checkInvalidFields(videoID: VideoID, userID: UserID, hashedUserID
const permission = await canSubmit(hashedUserID, segmentPair.category); const permission = await canSubmit(hashedUserID, segmentPair.category);
if (!permission.canSubmit) { if (!permission.canSubmit) {
Logger.warn(`Rejecting submission due to lack of permissions for category ${segmentPair.category}: ${segmentPair.segment} ${hashedUserID} ${videoID} ${videoDurationParam} ${userAgent}`);
invalidFields.push(`permission to submit ${segmentPair.category}`); invalidFields.push(`permission to submit ${segmentPair.category}`);
errors.push(permission.reason); errors.push(permission.reason);
} }
@@ -495,7 +496,7 @@ export async function postSkipSegments(req: Request, res: Response): Promise<Res
//hash the userID //hash the userID
const userID = await getHashCache(paramUserID || ""); const userID = await getHashCache(paramUserID || "");
const invalidCheckResult = await checkInvalidFields(videoID, paramUserID, userID, segments); const invalidCheckResult = await checkInvalidFields(videoID, paramUserID, userID, segments, videoDurationParam, userAgent);
if (!invalidCheckResult.pass) { if (!invalidCheckResult.pass) {
return res.status(invalidCheckResult.errorCode).send(invalidCheckResult.errorMessage); return res.status(invalidCheckResult.errorCode).send(invalidCheckResult.errorMessage);
} }