From 98cb2b022dae5ba9ff0819129e1af121c31b0028 Mon Sep 17 00:00:00 2001 From: "Michael M. Chang" Date: Fri, 10 Dec 2021 07:52:47 -0500 Subject: [PATCH 1/2] [searchSegments] ignore if votes <= -2 the ignored parameter should also ignore segments that are downvoted --- src/routes/getSearchSegments.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/routes/getSearchSegments.ts b/src/routes/getSearchSegments.ts index cbfb1f7..3d5e467 100644 --- a/src/routes/getSearchSegments.ts +++ b/src/routes/getSearchSegments.ts @@ -109,7 +109,7 @@ function filterSegments(segments: DBSegment[], page: number, filters: Record filters.maxViews) || (!filters.locked && segment.locked) || (!filters.hidden && segment.hidden) - || (!filters.ignored && (segment.hidden || segment.shadowHidden)) + || (!filters.ignored && ((segment.votes <= -2) || segment.hidden || segment.shadowHidden)) || (filters.categories.length > 0 && !filters.categories.includes(segment.category))) // return false if any of the conditions are met // return true if none of the conditions are met From 292b05443f015be5955efb4d5d09a3d5cdd68c27 Mon Sep 17 00:00:00 2001 From: Michael C Date: Fri, 10 Dec 2021 16:40:34 -0500 Subject: [PATCH 2/2] ignored segments should exclude downvote --- test/cases/getSearchSegments.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/test/cases/getSearchSegments.ts b/test/cases/getSearchSegments.ts index d330f55..2852f90 100644 --- a/test/cases/getSearchSegments.ts +++ b/test/cases/getSearchSegments.ts @@ -120,11 +120,10 @@ describe("getSearchSegments", () => { assert.strictEqual(res.status, 200); const data = res.data; const segments = data.segments; - assert.strictEqual(data.segmentCount, 3); + assert.strictEqual(data.segmentCount, 2); assert.strictEqual(data.page, 0); assert.strictEqual(segments[0].UUID, "search-normal"); - assert.strictEqual(segments[1].UUID, "search-downvote"); - assert.strictEqual(segments[2].UUID, "search-locked"); + assert.strictEqual(segments[1].UUID, "search-locked"); done(); }) .catch(err => done(err));