Merge pull request #432 from mchangrh/eslint-and-workflow

eslint + workflow formatting

.github/workflows/ci.yml

@@ -1,9 +1,13 @@
 name: SQLite CI
 
-on: [push, pull_request]
+on:
+  push:
+    branches:
+      - master
+  pull_request:
 
 jobs:
-  build:
+  test:
     name: Run Tests with SQLite
     runs-on: ubuntu-latest
 
@@ -12,7 +16,6 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v2
       - run: npm install
-
       - name: Run Tests
         timeout-minutes: 5
         run: npm test

.github/workflows/eslint.yml

@@ -1,9 +1,13 @@
 name: Linting
 
-on: [push, pull_request]
+on:
+  push:
+    branches:
+      - master
+  pull_request:
 
 jobs:
-  build:
+  lint:
     name: Lint with ESLint
     runs-on: ubuntu-latest
 
@@ -12,7 +16,6 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v2
       - run: npm install
-
       - name: Run Tests
         timeout-minutes: 5
         run: npm run lint

.github/workflows/generate-sqlite-base.yml

@@ -1,12 +1,17 @@
 name: create-sqlite-base
+
 on:
   push:
+    branches:
+      - master
     paths:
       - databases/**
 
 jobs:
   make-base-db:
+    name: Generate SQLite base .db
     runs-on: ubuntu-latest
+
     steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v2

.github/workflows/postgres-redis-ci.yml

@@ -1,9 +1,13 @@
 name: PostgreSQL + Redis CI
 
-on: [push, pull_request]
+on:
+  push:
+    branches:
+      - master
+  pull_request:
 
 jobs:
-  build:
+  test:
     name: Run Tests with PostgreSQL and Redis
     runs-on: ubuntu-latest
 

.github/workflows/take-action.yml

@@ -1,14 +1,12 @@
-# .github/workflows/take.yml 
 name: Assign issue to contributor
-on: 
+on: [issue_comment]
-  issue_comment:
 
 jobs:
   assign:
     name: Take an issue
     runs-on: ubuntu-latest
     steps:
-    - name: take the issue
+      - name: take the issue
-      uses: bdougie/take-action@main
+        uses: bdougie/take-action@main
-      env:
+        env:
-        GITHUB_TOKEN: ${{ github.token }}
+          GITHUB_TOKEN: ${{ github.token }}

src/app.ts

@@ -46,7 +46,6 @@ import { getChapterNames } from "./routes/getChapterNames";
 import { postRating } from "./routes/ratings/postRating";
 import { getRating } from "./routes/ratings/getRating";
 import { postClearCache as ratingPostClearCache } from "./routes/ratings/postClearCache";
-import path from "path";
 
 export function createServer(callback: () => void): Server {
     // Create a service (the app object is just a callback).

test/cases/ratings/getRating.ts

@@ -59,7 +59,7 @@ describe("getRating", () => {
     });
 
     /*
-    This test will fail if tests are already ran with redis. 
+    This test will fail if tests are already ran with redis.
     */
     it("Should be able to bulk fetch", (done) => {
         getBulkRating([videoOnePartialHash, videoTwoPartialHash])

test/cases/redisTest.ts

@@ -25,8 +25,8 @@ describe("redis test", function() {
     it("Should not be able to get not stored value", (done) => {
         redis.getAsync(randKey2)
             .then(res => {
-                if (res.reply || res.err ) assert.fail("Value should not be found")
+                if (res.reply || res.err ) assert.fail("Value should not be found");
                 done();
             });
-    })
+    });
 });