From 2c32460a6e9c698c70a3ca224c5b994e8ef08356 Mon Sep 17 00:00:00 2001
From: Joe Dowd <joedowd96@gmail.com>
Date: Mon, 31 Aug 2020 04:17:50 +0100
Subject: [PATCH] more tests

---
 src/routes/getSkipSegmentsByHash.js |  1 +
 test/cases/getSegmentsByHash.js     | 24 ++++++++++++++++++++++++
 2 files changed, 25 insertions(+)

diff --git a/src/routes/getSkipSegmentsByHash.js b/src/routes/getSkipSegmentsByHash.js
index eec0e0e..702a28d 100644
--- a/src/routes/getSkipSegmentsByHash.js
+++ b/src/routes/getSkipSegmentsByHash.js
@@ -2,6 +2,7 @@ const hashPrefixTester = require('../utils/hashPrefixTester.js');
 const getSegments = require('./getSkipSegments.js').cleanGetSegments;
 
 const databases = require('../databases/databases.js');
+const logger = require('../utils/logger.js');
 const db = databases.db;
 
 module.exports = async function (req, res) {
diff --git a/test/cases/getSegmentsByHash.js b/test/cases/getSegmentsByHash.js
index 1084ee3..6571fe4 100644
--- a/test/cases/getSegmentsByHash.js
+++ b/test/cases/getSegmentsByHash.js
@@ -100,6 +100,30 @@ describe('getSegmentsByHash', () => {
       });
   });
 
+  it('Should return 404 for no hash', (done) => {
+    request.get(utils.getbaseURL() 
+     + '/api/skipSegments/?categories=["shilling"]', null, 
+      (err, res, body) => {
+        if (err) done("Couldn't call endpoint");
+        else if (res.statusCode !== 404) done("expected 404, got " + res.statusCode);
+        else {
+          done(); // pass
+        }
+      });
+  });
+
+  it('Should return 500 for bad format categories', (done) => { // should probably be 400
+    request.get(utils.getbaseURL() 
+     + '/api/skipSegments/?categories=shilling', null, 
+      (err, res, body) => {
+        if (err) done("Couldn't call endpoint");
+        else if (res.statusCode !== 500) done("expected 500 got " + res.statusCode);
+        else {
+          done(); // pass
+        }
+      });
+  });
+
   it('Should be able to get multiple videos', (done) => {
     request.get(utils.getbaseURL() 
      + '/api/skipSegments/fdaf?categories=["sponsor","intro"]', null,