minor optimizations

This commit is contained in:
Michael C
2022-09-30 22:57:33 -04:00
parent 9ef0eafac1
commit 0b9e7029c5
2 changed files with 6 additions and 9 deletions

View File

@@ -128,12 +128,7 @@ async function handleGetSegments(req: Request, res: Response): Promise<searchSeg
const segments = await getSegmentsFromDBByVideoID(videoID, service); const segments = await getSegmentsFromDBByVideoID(videoID, service);
if (segments === null || segments === undefined) { if (!segments?.length) {
res.sendStatus(500);
return false;
}
if (segments.length === 0) {
res.sendStatus(404); res.sendStatus(404);
return false; return false;
} }
@@ -155,6 +150,7 @@ function filterSegments(segments: DBSegment[], filters: Record<string, any>, pag
); );
if (sortBy !== SortableFields.timeSubmitted) { if (sortBy !== SortableFields.timeSubmitted) {
/* istanbul ignore next */
filteredSegments.sort((a,b) => { filteredSegments.sort((a,b) => {
const key = sortDir === "desc" ? 1 : -1; const key = sortDir === "desc" ? 1 : -1;
if (a[sortBy] < b[sortBy]) { if (a[sortBy] < b[sortBy]) {
@@ -187,6 +183,7 @@ async function endpoint(req: Request, res: Response): Promise<Response> {
return res.send(segmentResponse); return res.send(segmentResponse);
} }
} catch (err) { } catch (err) {
/* istanbul ignore next */
if (err instanceof SyntaxError) { if (err instanceof SyntaxError) {
return res.status(400).send("Invalid array in parameters"); return res.status(400).send("Invalid array in parameters");
} else return res.sendStatus(500); } else return res.sendStatus(500);

View File

@@ -16,7 +16,7 @@ export async function getStatus(req: Request, res: Response): Promise<Response>
processTime = Date.now() - startTime; processTime = Date.now() - startTime;
return e.value; return e.value;
}) })
.catch(e => { .catch(e => /* istanbul ignore next */ {
Logger.error(`status: SQL query timed out: ${e}`); Logger.error(`status: SQL query timed out: ${e}`);
return -1; return -1;
}); });
@@ -25,7 +25,7 @@ export async function getStatus(req: Request, res: Response): Promise<Response>
.then(e => { .then(e => {
redisProcessTime = Date.now() - startTime; redisProcessTime = Date.now() - startTime;
return e; return e;
}).catch(e => { }).catch(e => /* istanbul ignore next */ {
Logger.error(`status: redis increment timed out ${e}`); Logger.error(`status: redis increment timed out ${e}`);
return [-1]; return [-1];
}); });
@@ -33,7 +33,7 @@ export async function getStatus(req: Request, res: Response): Promise<Response>
const statusValues: Record<string, any> = { const statusValues: Record<string, any> = {
uptime: process.uptime(), uptime: process.uptime(),
commit: (global as any).HEADCOMMIT || "unknown", commit: (global as any)?.HEADCOMMIT ?? "unknown",
db: Number(dbVersion), db: Number(dbVersion),
startTime, startTime,
processTime, processTime,