From f6109ace9973ad05ed3fac6094b34e3c1cacd271 Mon Sep 17 00:00:00 2001 From: mschae23 <46165762+mschae23@users.noreply.github.com> Date: Wed, 24 Sep 2025 21:32:49 +0200 Subject: [PATCH] =?UTF-8?q?Remove=20dead=20code=20and=20revert=20skip=20ac?= =?UTF-8?q?tion=20being=20changed=20to=20sentence=20case=20=F0=9F=98=AD?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/components/options/AdvancedSkipOptionsComponent.tsx | 6 +++--- src/utils/skipRule.ts | 8 ++------ 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/src/components/options/AdvancedSkipOptionsComponent.tsx b/src/components/options/AdvancedSkipOptionsComponent.tsx index 00f4230b..0975e9aa 100644 --- a/src/components/options/AdvancedSkipOptionsComponent.tsx +++ b/src/components/options/AdvancedSkipOptionsComponent.tsx @@ -93,13 +93,13 @@ function configToText(config: AdvancedSkipRule[]): string { result += "\nDisabled"; break; case CategorySkipOption.ShowOverlay: - result += "\nShow overlay"; + result += "\nShow Overlay"; break; case CategorySkipOption.ManualSkip: - result += "\nManual skip"; + result += "\nManual Skip"; break; case CategorySkipOption.AutoSkip: - result += "\nAuto skip"; + result += "\nAuto Skip"; break; default: return null; // Invalid skip option diff --git a/src/utils/skipRule.ts b/src/utils/skipRule.ts index f69e9a92..ad4c2fe0 100644 --- a/src/utils/skipRule.ts +++ b/src/utils/skipRule.ts @@ -229,7 +229,6 @@ type TokenType = export interface SourcePos { line: number; - // column: number; } export interface Span { @@ -275,11 +274,8 @@ function nextToken(state: LexerState): Token { state.current++; if (c === "\n") { - state.current_pos = { line: state.current_pos.line + 1, /* column: 1 */ }; - } else { - // // TODO This will be wrong on anything involving UTF-16 surrogate pairs or grapheme clusters with multiple code units - // // So just don't show column numbers on errors for now - // state.current_pos = { line: state.current_pos.line, /* column: state.current_pos.column + 1 */ }; + // Cannot use state.current_pos.line++, because SourcePos is mutable and used in tokens without copying + state.current_pos = { line: state.current_pos.line + 1, }; } return c;