From a8bd5d00685701dee2ad9626c78f53e70cb4c15d Mon Sep 17 00:00:00 2001 From: Owen D'Aprile <17219838+owendaprile@users.noreply.github.com> Date: Tue, 15 Oct 2019 17:46:42 -0400 Subject: [PATCH 1/3] Suppress Firefox error when changing tabs --- background.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/background.js b/background.js index 28fd6bb0..e397bb16 100644 --- a/background.js +++ b/background.js @@ -1,7 +1,7 @@ -chrome.tabs.onUpdated.addListener(function(tabId, changeInfo, tab) { +chrome.tabs.onUpdated.addListener(function(tabId) { chrome.tabs.sendMessage(tabId, { message: 'update', - }); + }, () => void chrome.runtime.lastError ); // Suppress error on Firefox }); chrome.runtime.onMessage.addListener(function (request, sender, callback) { From 047432af033716cdf981628d3472bd0349afae64 Mon Sep 17 00:00:00 2001 From: Owen D'Aprile <17219838+owendaprile@users.noreply.github.com> Date: Tue, 15 Oct 2019 17:48:40 -0400 Subject: [PATCH 2/3] Moved browser specific settings into manifest --- firefox_manifest-extra.json | 8 -------- manifest.json | 6 ++++++ 2 files changed, 6 insertions(+), 8 deletions(-) delete mode 100644 firefox_manifest-extra.json diff --git a/firefox_manifest-extra.json b/firefox_manifest-extra.json deleted file mode 100644 index 7625cd66..00000000 --- a/firefox_manifest-extra.json +++ /dev/null @@ -1,8 +0,0 @@ -{ - "browser_specific_settings": { - "gecko": { - "id": "sponsorBlocker@ajay.app", - "strict_min_version": "57.0" - } - } -} diff --git a/manifest.json b/manifest.json index 10778193..494ac8b0 100644 --- a/manifest.json +++ b/manifest.json @@ -65,5 +65,11 @@ "128": "icons/LogoSponsorBlocker128px.png", "256": "icons/LogoSponsorBlocker256px.png" }, + "browser_specific_settings": { + "gecko": { + "id": "sponsorBlocker@ajay.app", + "strict_min_version": "57.0" + } + }, "manifest_version": 2 } From 01405dd32ebd453367b166412214dd8ff77bb845 Mon Sep 17 00:00:00 2001 From: Owen D'Aprile <17219838+owendaprile@users.noreply.github.com> Date: Tue, 15 Oct 2019 17:49:01 -0400 Subject: [PATCH 3/3] Ignore WebStorm project configuration folder --- .gitignore | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index 0af10d9b..1bd01fa0 100644 --- a/.gitignore +++ b/.gitignore @@ -1,2 +1,3 @@ config.js -ignored \ No newline at end of file +ignored +.idea/ \ No newline at end of file