Mirror/SponsorBlock
1
0
Fork 0
mirror of https://github.com/ajayyy/SponsorBlock.git synced 2025-12-13 06:57:09 +03:00
Code Issues Packages Projects Releases Wiki Activity

Reduced execution time of hexToRgb function by ~70%

Browse Source 
Coded to use less regex.
On average, "indexOf" performs better than "parseInt."
This commit is contained in:
Bennett
2022-10-13 14:48:17 -04:00
committed by GitHub
parent 97fc8174b9
commit edaed61612
1 changed files with 12 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/utils/genericUtils.ts
View File

@@ -92,20 +92,17 @@ function getLuminance(color: string): number {
return Math.sqrt(0.299 * (r * r) + 0.587 * (g * g) + 0.114 * (b * b)); return Math.sqrt(0.299 * (r * r) + 0.587 * (g * g) + 0.114 * (b * b));
} }
/* From https://stackoverflow.com/a/5624139 */ /* Converts hex color to rgb color */
function hexToRgb(hex: string): {r: number; g: number; b: number} { const hexChars = "0123456789abcdef";
// Expand shorthand form (e.g. "03F") to full form (e.g. "0033FF") function hexToRgb(hex: string): { r: number; g: number; b: number } | null {
const shorthandRegex = /^#?([a-f\d])([a-f\d])([a-f\d])$/i; if (hex.length == 4)
hex = hex.replace(shorthandRegex, function(m, r, g, b) { hex = "#" + hex[1] + hex[1] + hex[2] + hex[2] + hex[3] + hex[3];
return r + r + g + g + b + b; return /^#?([a-f\d]{2})([a-f\d]{2})([a-f\d]{2})$/i.exec(hex)
}); ? {
r: hexChars.indexOf(hex[1]) * 16 + hexChars.indexOf(hex[2]),
const result = /^#?([a-f\d]{2})([a-f\d]{2})([a-f\d]{2})$/i.exec(hex); g: hexChars.indexOf(hex[3]) * 16 + hexChars.indexOf(hex[4]),
return result ? { b: hexChars.indexOf(hex[5]) * 16 + hexChars.indexOf(hex[6]),
r: parseInt(result[1], 16), }: null;
g: parseInt(result[2], 16),
b: parseInt(result[3], 16)
} : null;
} }
/** /**