Mirror/SponsorBlock
1
0
Fork 0
mirror of https://github.com/ajayyy/SponsorBlock.git synced 2025-12-09 13:07:05 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix potential infinite loop in skip notice

Browse Source
This commit is contained in:
Ajay Ramachandran
2021-06-09 14:57:24 -04:00
parent 4932fc6f45
commit dacf766b4a
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/render/SkipNotice.tsx
View File

@@ -24,6 +24,10 @@ class SkipNotice {
//get reference node //get reference node
let referenceNode = document.getElementById("player-container-id") let referenceNode = document.getElementById("player-container-id")
|| document.getElementById("movie_player") || document.querySelector("#player-container .video-js"); || document.getElementById("movie_player") || document.querySelector("#player-container .video-js");
// YouTube Music
if (new URL(document.URL).host === "music.youtube.com") {
referenceNode = document.querySelector("#main-panel.ytmusic-player-page");
}
if (referenceNode == null) { if (referenceNode == null) {
//for embeds //for embeds
const player = document.getElementById("player"); const player = document.getElementById("player");
@@ -31,16 +35,13 @@ class SkipNotice {
let index = 1; let index = 1;
//find the child that is the video player (sometimes it is not the first) //find the child that is the video player (sometimes it is not the first)
while (!referenceNode.classList.contains("html5-video-player") || !referenceNode.classList.contains("ytp-embed")) { while (index < player.children.length && (!referenceNode.classList.contains("html5-video-player") || !referenceNode.classList.contains("ytp-embed"))) {
referenceNode = player.children[index] as HTMLElement; referenceNode = player.children[index] as HTMLElement;
index++; index++;
} }
} }
// YouTube Music
if (new URL(document.URL).host === "music.youtube.com") {
referenceNode = document.querySelector("#main-panel.ytmusic-player-page");
}
const amountOfPreviousNotices = document.getElementsByClassName("sponsorSkipNotice").length; const amountOfPreviousNotices = document.getElementsByClassName("sponsorSkipNotice").length;
//this is the suffix added at the end of every id //this is the suffix added at the end of every id