Changed the way it detects when a page is not YouTube and prevented lastError.

This commit is contained in:
Ajay Ramachandran
2019-07-10 11:55:09 -04:00
parent 9218aed94e
commit 493fb3fc72

View File

@@ -25,14 +25,6 @@ chrome.storage.local.get(["dontShowNoticeAgain"], function(result) {
} }
}); });
//if no response comes by this point, give up
setTimeout(function() {
if (!isYouTubeTab) {
document.getElementById("loadingIndicator").innerHTML = "This probably isn't a YouTube tab, or you clicked too early. " +
"If you know this is a YouTube tab, close this popup and open it again.";
}
}, 100);
chrome.tabs.query({ chrome.tabs.query({
active: true, active: true,
currentWindow: true currentWindow: true
@@ -72,6 +64,13 @@ function loadTabData(tabs) {
} }
function infoFound(request) { function infoFound(request) {
if(chrome.runtime.lastError) {
//This page doesn't have the injected content script, or at least not yet
document.getElementById("loadingIndicator").innerHTML = "This probably isn't a YouTube tab, or you clicked too early. " +
"If you know this is a YouTube tab, close this popup and open it again.";
return;
}
//if request is undefined, then the page currently being browsed is not YouTube //if request is undefined, then the page currently being browsed is not YouTube
if (request != undefined) { if (request != undefined) {
//this must be a YouTube video //this must be a YouTube video